You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nice work @abhinavn2206146 ! 🎊
I really appreciate your thought process you applied for filtering the data. 😎
Issues with the commit
Use of Json file
Now what I really wanted you to do was do the processing on the data from the json file itself.
Sure, the data for this assignment was too short so hard coding that data in your user defined class was quite a smart move!
Now lets imagine a situation where this data is in 100s or even 1000s lines of code. To make things even worse, what if the data is DYNAMIC , changes all the time...
You see in these cases hard coding the data is not going to work for too long. So try to fetch data from json file itself using different properties of maps and keys and values.
Making the app responsive
As I mentioned, try not to hard code sizes of widgets rather make it flexible according to the device.
Use different simulators or physical devices to build the responsiveness.
Use media query, screenUtil packages to achieve the goal
@abhinavn2206146 you have declared and defined a variable isLandscape but haven't used it.
try to build the application around the orientation of the device and resize widgets or make them scrollable as per the orientation to avoid overflow errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.