Skip unsupported plugins instead of raising KeyError (#95)

* Skip unsupported plugins instead of raising KeyError

* Remove explanatory comment in create_plugin

---------

Co-authored-by: Jack Hughes <jackthughes@yahoo.com>

Author: atudor2

openrgb/orgb.py

@@ -420,7 +420,10 @@ def _callback(self, device: int, type: int, data: Any):
         elif type == utils.PacketType.REQUEST_PLUGIN_LIST:
             for plugin in data:
                 if (all(plugin.id != existing.id for existing in self.plugins)):
-                    self.plugins.append(create_plugin(plugin, self.comms))
+                    # Plugins that are not supported should be skipped
+                    new_plugin = create_plugin(plugin, self.comms)
+                    if new_plugin is not None:
+                        self.plugins.append(new_plugin)
         elif type == utils.PacketType.PLUGIN_SPECIFIC:
             next(plugin for plugin in self.plugins if plugin.id == device)._recv(data)
 

openrgb/plugins/__init__.py

@@ -1,4 +1,5 @@
 from __future__ import annotations
+from typing import Optional
 from openrgb.utils import Plugin
 from openrgb.network import NetworkClient
 from openrgb.plugins.common import ORGBPlugin
@@ -10,5 +11,8 @@
 }
 
 
-def create_plugin(plugin: Plugin, comms: NetworkClient) -> ORGBPlugin:
-    return PLUGIN_NAMES[plugin.name](plugin, comms)
+def create_plugin(plugin: Plugin, comms: NetworkClient) -> Optional[ORGBPlugin]:
+    plugin_class = PLUGIN_NAMES.get(plugin.name)
+    if plugin_class is None:
+        return None
+    return plugin_class(plugin, comms)