Repository navigation
Skip unsupported plugins instead of raising KeyError - #95
Merged
Merged
Conversation
10 of 21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found an issue when using the OpenRGB integration via Home Assistant - if there is a disabled/unsupported plugin installed on the OpenRGB server, create_plugin() throws a KeyError due to the unconditional lookup to PLUGIN_NAMES.
In my case, the OpenRGB server returned an entirely empty plugin entry (name, description and version all empty strings) for the disabled plugin which then failed with a "KeyError: ''".
This is a small change to check if the plugin is actually supported and returns None if not