Fix pagination param: use limit instead of batchSize for affected endpoints - #1
Merged
Conversation
…tchSize The Data 360 API is inconsistent — some endpoints use `batchSize` as the page-size query parameter while others use `limit`. The SDK was hardcoding `batchSize` everywhere, causing pagination to silently fail on ~22 endpoints that expect `limit` (the API would ignore the unrecognized param and use its default page size). Add a `pageSizeParam` option to the pagination infrastructure and set it to `"limit"` in all affected resources: connections, data-clean-room, data-lake-objects, data-model-objects, data-spaces, data-streams, data-transforms, document-ai, machine-learning, private-network-routes, and segments (listMembers).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
batchSizeon some endpoints andlimiton others as the page-size query parameterbatchSizeeverywhere, silently breaking pagination on ~22limit-based endpointspageSizeParamoption to the pagination infrastructure ("batchSize"default,"limit"where needed)pageSizeParam: "limit"on the correct endpointsAffected resources: connections, data-clean-room, data-lake-objects, data-model-objects, data-spaces, data-streams, data-transforms, document-ai, machine-learning, private-network-routes, segments (listMembers)
Test plan
pageSizeParam: "limit"inpagination.test.tsdata-streams.test.tsto assertlimitis sentconnections.test.tsandsegments.test.tsassertionsRelease
After merging, create a GitHub release with tag
v0.1.1to trigger the npm publish workflow.