Fix query params on HTTP methods and pagination extraction - #2
Merged
Conversation
- Add optional query parameter to post(), put(), patch(), delete() on HttpClient (the underlying request() already supported it) - Add query param support to delete() on all resource services, enabling e.g. shouldDeleteDataLakeObject on dataStreams.delete() - Fix paginate() extractItems to auto-detect array properties on collection responses (dataStreams, connections, dataLakeObjects, etc.) instead of only checking data/metadata/records
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
queryparameter topost(),put(),patch(), anddelete()methods. The underlyingrequest()already supported query params — these just needed the type exposed.queryin their delete options, enabling spec-defined params likeshouldDeleteDataLakeObjectondataStreams.delete().extractItems()to auto-detect array-valued properties on collection responses (dataStreams,connections,dataLakeObjects, etc.) instead of only checkingdata/metadata/records. This eliminates the need foras anycasts when usinglistAll().All changes validated against the OpenAPI spec.
Test plan
npx tsc --noEmitpassesdataStreams.delete(id, { query: { shouldDeleteDataLakeObject: true } })works against a live instancelistAll()yields typed items withoutas anyfor dataStreams, connections, dataLakeObjects