Skip to content

Commit 22187df

Browse files
committed
Regenerate the laptop index and clean up the merged entries
Merging #12 and #13 together left the model-listing count at 31: both PRs bumped it from 30 to 31 independently, so git took the identical change once and the real total of 32 never landed. The repo-consistency check caught it on master. Also drops the empty patches/.gitkeep from the gxfp5187 entry, since patches/README.md already keeps the directory, and replaces the em-dashes the two entries brought in with plain punctuation.
1 parent 8bbfcf9 commit 22187df

6 files changed

Lines changed: 12 additions & 12 deletions

File tree

devices/27c6:55b4/patches/0008-README-document-the-Goodix-55b4-fork-build-enroll-tu.patch

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ index 2e52403..41b8703 100644
8181
+
8282
+### If verify suddenly fails
8383
+
84-
+`verify-disconnected` / instant "Wrong" usually means a stale TLS session run
84+
+`verify-disconnected` / instant "Wrong" usually means a stale TLS session, so run
8585
+`sudo pkill -9 -x fprintd` to force a fresh cold handshake. If it persists, the
8686
+sensor PSK was likely rewritten (e.g. by a Windows Hello boot, which can't share
8787
+the sensor with Linux); re-enroll to re-provision it.

devices/gxfp5187/CREDITS

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,20 @@ Driver and protocol reverse-engineering:
44
Base: commit d7ed1db (branch main), against libfprint-2-tod1 1.94.7+tod1.
55

66
Reference work this build relied on:
7-
JJJollyjim wireshark-goodix: Wireshark dissector for the GXFP5187 SPI
7+
JJJollyjim - wireshark-goodix: Wireshark dissector for the GXFP5187 SPI
88
protocol, with a sample SPI capture. The key protocol reference.
99
https://github.com/JJJollyjim/wireshark-goodix
10-
PeshalaDilshan OpenGoodixSPI: experimental kernel driver for Goodix SPI
10+
PeshalaDilshan - OpenGoodixSPI: experimental kernel driver for Goodix SPI
1111
sensors, GXFP5187 referenced.
1212
https://github.com/PeshalaDilshan/OpenGoodixSPI
13-
lexakimov goodix51c0_spi-reversing: Goodix 51C0 SPI protocol RE.
13+
lexakimov - goodix51c0_spi-reversing: Goodix 51C0 SPI protocol RE.
1414
https://github.com/lexakimov/goodix51c0_spi-reversing
15-
goodix-fp-linux-dev goodix-fp-dump: Goodix USB protocol work, useful for
15+
goodix-fp-linux-dev - goodix-fp-dump: Goodix USB protocol work, useful for
1616
comparison. https://github.com/goodix-fp-linux-dev/goodix-fp-dump
17-
archshift goodix_fingerprint_re: Goodix driver RE (Dell XPS 15 2019).
17+
archshift - goodix_fingerprint_re: Goodix driver RE (Dell XPS 15 2019).
1818
https://github.com/archshift/goodix_fingerprint_re
1919

2020
Matcher technique references:
2121
D. Lowe, "Distinctive Image Features from Scale-Invariant Keypoints" (2004).
2222
Arandjelović & Zisserman, "Three things everyone should know to improve
23-
object retrieval" RootSIFT (2012).
23+
object retrieval" - RootSIFT (2012).

devices/gxfp5187/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Enrols and verifies through `fprintd` and GNOME Settings; session unlock and
88
Upstream libfprint has no driver for this sensor (tracked in
99
[libfprint issue #112](https://gitlab.freedesktop.org/libfprint/libfprint/-/issues/112)).
1010
This entry points at an out-of-tree **TOD** driver (a shared module libfprint
11-
loads at runtime), not a patch against libfprint's own sources — see
11+
loads at runtime), not a patch against libfprint's own sources. See
1212
[patches/](patches/) for the base version and where the code lives.
1313

1414
The driver, its full protocol write-up and the reasoning behind the matcher are
@@ -24,7 +24,7 @@ are listed here.
2424
- **It is SPI, not USB.** libfprint reaches it through the `spidev` node. The
2525
`spidev` kernel module must be bound to the SPI device (`spi-GXFP5187:00`);
2626
the driver ships a udev rule that does this on every appearance. `spidev` has
27-
no alias for this hardware, so nothing loads it on its own the install
27+
no alias for this hardware, so nothing loads it on its own, so the install
2828
step forces it.
2929
- **`spidev` must be given a larger buffer.** The image arrives as a single
3030
~22 kB SPI transfer, above the 4096-byte default; `options spidev

devices/gxfp5187/patches/.gitkeep

Whitespace-only changes.

devices/gxfp5187/patches/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# Patches
22

3-
This sensor is served by an out-of-tree **TOD** driver a shared module that
4-
libfprint loads at runtime not by a patch series against libfprint's own
3+
This sensor is served by an out-of-tree **TOD** driver, a shared module that
4+
libfprint loads at runtime, not by a patch series against libfprint's own
55
source tree. There are therefore no `.patch` files here; the code lives in its
66
own repository and is built and installed as a module.
77

docs/laptops.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ lsusb # find the reader, e.g. 27c6:55b4
1717
then look it up in the [main README](../README.md), or run
1818
`./tools/detect.sh` to have it matched for you.
1919

20-
31 model listings map to a catalogued sensor; the rest are on the
20+
32 model listings map to a catalogued sensor; the rest are on the
2121
gap-map with no known fix, and a protocol dump for any of them is welcome.
2222

2323
**Adding your machine** is the single most useful small contribution here.

0 commit comments

Comments
 (0)