Add AC4 audio codec for supporting device profiles - #5638
Conversation
nielsvanvelzen
left a comment
There was a problem hiding this comment.
Normally reviews only happen after a PR goes out of draft but @BotBlake asked me "kindly" to review this while in draft.
Have you tested the "supportsAC4" function on a devices that should or shouldn't support AC4 and did they return the expected results?
Most of my coding experience up to this point has been debuggerless so I'm used to trying to implement the whole thing and then test the feature and playing whack-a-mole from there 🗿🫠. It makes sense that I should be able to do that and I will before I ask for help again next time 🫡. |
# Conflicts: # app/src/main/java/org/jellyfin/androidtv/util/profile/MediaCodecCapabilitiesTest.kt
|
Needs testing with devices that support AC4 as the CCwGTV doesn't seem to support it based on the debugger. |
Checking AC4 support and including in Device Profile
Changes
Current changes are setting it up so that we have AC4 as a codec that can be checked during device profile creation.
Created the function next to the other video codec checks in MediaCodecCapabilitiesTest.kt. Modified the codec object to include AC4 in Codec.kt. Added the codec in deviceProfile.kt.
I'm currently planning to do a check and filter for if the device supports the codec using the function defined in MediaCodecCapabilitiesTest.kt to determine if the codec needs filtered out kind of like you do here using the settings section in the createDeviceProfileFunction.
I'm assuming it shouldn't be inside of the same block above but wasn't sure how/where you would want to implement it.
Code assistance
N/A
Issues
#4666