Add user preferences to force enable or disable common HDR formats - #5743
Open
clowncracker wants to merge 4 commits into
Open
Add user preferences to force enable or disable common HDR formats#5743clowncracker wants to merge 4 commits into
clowncracker wants to merge 4 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Add trailing newline to HdrFormat.kt
Member
|
Please fill in the pull request template |
|
Any hope this get merged soon? Jellyfin is unusable on Android TV projectors without it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Continues #5613 (originally by @clams4shoes), addressing @nielsvanvelzen's review feedback: added named parameters to the HdrFormat enum entries, and renamed the HDR override preference keys to drop the
pref_prefix so each key matches its variable name. The detection refactor and the "Auto (enabled/disabled)" label are left for follow-up PRs per his notes.Code assistance
The original code in #5613 was partially generated by an LLM (per @clams4shoes's note there). For this continuation, I used an LLM (Claude Opus 4.8) to implement @nielsvanvelzen's requested review changes. I manually reviewed the changes and uploaded them myself.
Issues
Fixes #5073
Fixes #5091
Notes
Continuation of #5613. Supersedes #5116