freerdp3: add host pkg-config dependency to unblock 3.30.0 configure - #66
Merged
Merged
Conversation
Copilot created this pull request from a session on behalf of
jens-maus
July 23, 2026 20:33
View session
jens-maus
marked this pull request as ready for review
July 23, 2026 20:33
jens-maus
added a commit
that referenced
this pull request
Aug 20, 2026
Add a new external freerdp3 package derived from Buildroot's freerdp packaging and pin it to FreeRDP 3.30.0. Wire it into external Config.in and switch generic-x86_64 to freerdp3. Drop/rename obsolete FreeRDP2-era CMake flags for the FreeRDP 3.30.0 package wiring, and add a dedicated BR2_PACKAGE_FREERDP3_RDPECAM toggle that enables CHANNEL_RDPECAM and CHANNEL_RDPECAM_CLIENT with libv4l/libusb dependencies. Enable it in generic-x86_64 config. * freerdp3: add host-pkgconf build dependency (#66) * freerdp3: disable kerberos when krb5 is unavailable (#67) * use host dir pkg-config * add BR2_PACKAGE_FREERDP3_FUSE * remove obsolete FREERDP3_INSTALL_KEYS * add more cleanup stuff * fix buildroot package check linter error * add WITH_VERBOSE_WINPR_ASSERT=OFF * fix circular dependency issue * finalize freerdp 3.30.0 compile options * enable freerdp3 for all platforms * fix shellcheck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FreeRDP 3.30.0 configuration now fails in
FindKRB5.cmakebecausePkgConfigis treated as required andPKG_CONFIG_EXECUTABLEis unavailable in the host build environment. This preventsfreerdp3from reaching build generation.Root cause
freerdp3package dependencies did not include a host-side pkg-config provider, so CMake could not resolvefind_package(PkgConfig)when evaluating KRB5 detection paths.Packaging change
host-pkgconftoFREERDP3_DEPENDENCIESin:/home/runner/work/thinRoot/thinRoot/buildroot-external/package/freerdp3/freerdp3.mkPKG_CONFIG_EXECUTABLEis present during configure-time feature detection.Patch excerpt