Skip to content

docs(glossary): SkillVersion (14th entity) + Skill Refiner brand-canon terms (0r8m.5) - #181

Merged
jeremylongshore merged 2 commits into
mainfrom
docs/iel-0r8m5-refiner-glossary
Jun 20, 2026
Merged

docs(glossary): SkillVersion (14th entity) + Skill Refiner brand-canon terms (0r8m.5)#181
jeremylongshore merged 2 commits into
mainfrom
docs/iel-0r8m5-refiner-glossary

Conversation

@jeremylongshore

Copy link
Copy Markdown
Owner

Adds the 6 Skill Refiner brand-canon entries to the canonical glossary (014-DR-GLOS) per the ratified DR-028 plan:

  • § 2.14 SkillVersion — the 14th canonical entity (DR-028 T1 DISCRIMINATOR; shipped in @intentsolutions/core@0.8.0). § 2 heading bumped 13 → 14.
  • § 3 operational terms: Skill Refiner, 3-layer hooks (sinker/line/hook), EditProposal, ScoreRecord, Skill Refiner evidence reports.

Each entry follows the existing glossary format and cross-links Plan 027 (v5; supersedes 025) + Blueprint B § 7 + DR-028. Per DR-010 § 13.6 the entries explain IS-native concepts and cite prior art for design context only.

Placed to avoid renumbering §§ 9–10 (which are internally cross-referenced). Green locally: markdownlint (CI cli2 0.22.1), prettier@3.8.4, lychee, partner-name guard (0 hits).

Beads: bd_000-projects-0r8m.5

…s (0r8m.5)

Add 6 canonical-glossary entries for the ratified DR-028 Skill Refiner brand canon:
- § 2.14 SkillVersion — the 14th canonical entity (DR-028 T1 DISCRIMINATOR);
  bump the § 2 heading 13 → 14 + note SkillVersion sits outside Blueprint B § 2.
- § 3 (operational terms): Skill Refiner, 3-layer hooks (sinker/line/hook),
  EditProposal, ScoreRecord, Skill Refiner evidence reports.

Each cites Plan 027 (v5; supersedes 025) + Blueprint B § 7 + DR-028. IS-native
concepts; prior art cited for design context only (DR-010 § 13.6).
markdownlint (CI cli2 0.22.1) + prettier@3.8.4 + lychee + partner-name guard all green.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the canonical glossary document to include SkillVersion as the 14th canonical entity and introduces several operational terms related to the Skill Refiner tool. The review feedback focuses on maintaining document consistency, suggesting updates to the reading guide, the alphabetical index, and the predicate type lists to reflect these additions, as well as formatting the new terms in lowercase to match existing entries.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread 000-docs/014-DR-GLOS-canonical-glossary.md
Comment thread 000-docs/014-DR-GLOS-canonical-glossary.md
Comment thread 000-docs/014-DR-GLOS-canonical-glossary.md
Comment thread 000-docs/014-DR-GLOS-canonical-glossary.md
Comment thread 000-docs/014-DR-GLOS-canonical-glossary.md
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jeremylongshore, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 49 minutes and 47 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9d565573-b444-458c-8737-f0a5e2f45e9d

📥 Commits

Reviewing files that changed from the base of the PR and between 61f9a30 and 885e6c1.

📒 Files selected for processing (1)
  • 000-docs/014-DR-GLOS-canonical-glossary.md
📝 Walkthrough

Walkthrough

The glossary document 014-DR-GLOS-canonical-glossary.md is updated in three areas. §2's header is revised from 13 to 14 canonical entities, noting SkillVersion as the 14th with schema authority in schemas/v1/skill-version.schema.json rather than Blueprint B. A new §2.14 subsection defines SkillVersion as the Skill Refiner refinement-lineage record, enumerates its core fields (version_kind, parent_version_id, source_snapshot_hash, refiner_strategy_id), and states shipped minimal-scope constraints. §3 gains five new operational-term entries covering the Skill Refiner product, 3-layer hooks, EditProposal, ScoreRecord, and Skill Refiner evidence reports.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Title accurately summarizes the main change: adding SkillVersion as the 14th canonical entity and Skill Refiner operational terms to the glossary.
Description check ✅ Passed Description directly addresses the changeset: documents 6 glossary entries (SkillVersion + 5 Skill Refiner terms), cites DR-028 plan, references validation tools, and explains placement rationale.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/iel-0r8m5-refiner-glossary

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@000-docs/014-DR-GLOS-canonical-glossary.md`:
- Line 150: In the SkillVersion entity definition within the canonical glossary,
replace the word "nullable" with "can be null" where it currently describes the
parent_version_id property. Specifically, locate the phrase about
parent_version_id in the SkillVersion section and change "nullable for a root
version" to "can be null for a root version" to satisfy the Vale docs linter
requirements while maintaining the same meaning.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: c020d524-6c51-4dd0-9968-9e819e4f2184

📥 Commits

Reviewing files that changed from the base of the PR and between 1ef28dd and 61f9a30.

📒 Files selected for processing (1)
  • 000-docs/014-DR-GLOS-canonical-glossary.md

Comment thread 000-docs/014-DR-GLOS-canonical-glossary.md Outdated
- § 1 reading guide: "13 canonical entities" → "14" (matched the § 2 heading).
- § 9 alphabetical index: add the 6 new terms (3-layer hooks, EditProposal,
  ScoreRecord, Skill Refiner, Skill Refiner evidence reports, SkillVersion).
- § 6 signing terms: document skill-refiner-pass/v1 (DR-082, staging) — the
  predicate the new entries reference.
- § 2.14: "nullable" → "can be null" (CodeRabbit/Vale quick win).
- Group the 5 Refiner terms under a "### Skill Refiner subsystem terms"
  subheading so the capitalized product/type proper nouns don't clash with
  § 3's lowercase common-noun verbs (cleaner than lowercasing a product name —
  Skill Refiner is named per DR-028 T4 KEEP-NAMED-PRODUCT).
@jeremylongshore
jeremylongshore merged commit 181de2c into main Jun 20, 2026
15 of 17 checks passed
@jeremylongshore
jeremylongshore deleted the docs/iel-0r8m5-refiner-glossary branch June 20, 2026 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant