Skip to content

Commit f5554e5

Browse files
committed
Revert "Fold the interpreter's pathlib rendering out of the signature comparison"
This reverts commit 1fc0fe5.
1 parent 1fc0fe5 commit f5554e5

1 file changed

Lines changed: 1 addition & 7 deletions

File tree

tests/test_shared_baseline_resolution.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -300,17 +300,11 @@ def test_the_five_resolvers_keep_their_signatures():
300300
default or moved a parameter between positional and keyword-only reports a
301301
different string here. The `HARNESS_ROOT` default renders as the repository
302302
path, which would make this a machine-specific literal, so it is folded
303-
back to the name it is written under. The `Path` annotation is folded for
304-
the same reason and it is an interpreter difference rather than a machine
305-
one: 3.13 split `pathlib` internally and renders the annotation as
306-
`pathlib._local.Path`, where 3.10 and 3.14 render `pathlib.Path`. The type
307-
is the same type, so the fold keeps this an assertion about the resolvers'
308-
signatures rather than about which interpreter read them.
303+
back to the name it is written under.
309304
"""
310305
for name, expected in RESOLVER_SIGNATURES.items():
311306
rendered = str(inspect.signature(getattr(conftest, name)))
312307
rendered = rendered.replace(repr(conftest.HARNESS_ROOT), "HARNESS_ROOT")
313-
rendered = rendered.replace("pathlib._local.Path", "pathlib.Path")
314308
assert rendered == expected, name
315309

316310
# The control: the comparison can differ. A resolver's signature read

0 commit comments

Comments
 (0)