Fix crash on Windows when using Cygwin Git - #5984
Open
500-internal-server-error wants to merge 1 commit into
Open
Fix crash on Windows when using Cygwin Git#5984500-internal-server-error wants to merge 1 commit into
500-internal-server-error wants to merge 1 commit into
Conversation
Also disable some tests due to cygpath being impossible to test hermetically
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Fix crash on Windows when using Cygwin Git by running Unix paths through
cygpath. I also thought of just doing the path fixup manually but technicallycygpathcovers a lot of edge cases that a simple/naive path fixup will probably not, so I went with that. On the other hand,mingw-w64-gitrecently happened, so maybe this patch isn't needed, but I think it would still be nice to support Cygwingit.Closes:
Please check if the PR fulfills these requirements
go generate ./...)