Skip to content

Fix crash on Windows when using Cygwin Git - #5984

Open
500-internal-server-error wants to merge 1 commit into
jesseduffield:masterfrom
500-internal-server-error:support-cygwin-git
Open

Fix crash on Windows when using Cygwin Git#5984
500-internal-server-error wants to merge 1 commit into
jesseduffield:masterfrom
500-internal-server-error:support-cygwin-git

Conversation

@500-internal-server-error

Copy link
Copy Markdown

PR Description

Fix crash on Windows when using Cygwin Git by running Unix paths through cygpath. I also thought of just doing the path fixup manually but technically cygpath covers a lot of edge cases that a simple/naive path fixup will probably not, so I went with that. On the other hand, mingw-w64-git recently happened, so maybe this patch isn't needed, but I think it would still be nice to support Cygwin git.

Closes:

Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
    • e2e tests don't work on Windows
  • Text is internationalised (see here)
    • No new user-facing UI text is added
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
    • No configs are added
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

Also disable some tests due to cygpath being impossible to test hermetically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant