-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat(jest-snapshot): support ESM snapshotResolver and snapshotSerializers #16402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
soltonigiri
wants to merge
8
commits into
jestjs:main
Choose a base branch
from
soltonigiri:feat/esm-snapshot-modules-11167
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8f45697
feat(jest-snapshot): support ESM snapshotResolver and snapshotSeriali…
soltonigiri fc732bb
chore: add changelog entry for #16402
soltonigiri 6e5f87e
test: cover snapshot setup and label docs tabs
soltonigiri 7ecf8f0
fix(jest-snapshot): address ESM resolver review feedback
soltonigiri 1175936
Merge branch 'main' into feat/esm-snapshot-modules-11167
SimenB 291d8ff
fix(jest-snapshot): address follow-up review feedback
soltonigiri e7e51fe
test(e2e): configure ESM snapshot resolver transform
soltonigiri b9194a4
Merge branch 'main' into feat/esm-snapshot-modules-11167
soltonigiri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| /** | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| test('snapshots are written to custom location', () => { | ||
| expect('foobar').toMatchSnapshot(); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| /** | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| export default { | ||
| resolveSnapshotPath: (testPath, snapshotExtension) => | ||
| testPath.replace('__tests__', '__snapshots__') + snapshotExtension, | ||
|
|
||
| resolveTestPath: (snapshotFilePath, snapshotExtension) => | ||
| snapshotFilePath | ||
| .replace('__snapshots__', '__tests__') | ||
| .slice(0, -snapshotExtension.length), | ||
|
|
||
| testPathForConsistencyCheck: 'foo/__tests__/bar.test.js', | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "jest": { | ||
| "testEnvironment": "node", | ||
| "snapshotResolver": "<rootDir>/customSnapshotResolver.mjs" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| /** | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| test('uses the first matching serializer', () => { | ||
| expect({kind: 'both', value: 'value'}).toMatchSnapshot(); | ||
| }); | ||
|
|
||
| test('loads every configured serializer', () => { | ||
| expect({kind: 'second', value: 'value'}).toMatchSnapshot(); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "jest": { | ||
| "testEnvironment": "node", | ||
| "snapshotSerializers": [ | ||
| "<rootDir>/plugins/first.mjs", | ||
| "<rootDir>/plugins/second.mjs" | ||
| ] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| /** | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| export default { | ||
| serialize: value => `first: ${value.value}`, | ||
| test: value => value?.kind === 'both', | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| /** | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| export default { | ||
| serialize: value => `second: ${value.value}`, | ||
| test: value => value?.kind === 'both' || value?.kind === 'second', | ||
| }; |
10 changes: 10 additions & 0 deletions
10
e2e/transform/transform-esm-snapshotResolver/__tests__/snapshot.test.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| /** | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| test('snapshots are written to custom location', () => { | ||
| expect('foobar').toMatchSnapshot(); | ||
| }); |
18 changes: 18 additions & 0 deletions
18
e2e/transform/transform-esm-snapshotResolver/babel.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| /** | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| module.exports = { | ||
| presets: [ | ||
| [ | ||
| '@babel/preset-env', | ||
| { | ||
| modules: 'commonjs', | ||
| targets: {node: 'current'}, | ||
| }, | ||
| ], | ||
| ], | ||
| }; |
18 changes: 18 additions & 0 deletions
18
e2e/transform/transform-esm-snapshotResolver/customSnapshotResolver.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| /** | ||
| * Copyright (c) Meta Platforms, Inc. and affiliates. | ||
| * | ||
| * This source code is licensed under the MIT license found in the | ||
| * LICENSE file in the root directory of this source tree. | ||
| */ | ||
|
|
||
| export default { | ||
| resolveSnapshotPath: (testPath, snapshotExtension) => | ||
| testPath.replace('__tests__', '__snapshots__') + snapshotExtension, | ||
|
|
||
| resolveTestPath: (snapshotFilePath, snapshotExtension) => | ||
| snapshotFilePath | ||
| .replace('__snapshots__', '__tests__') | ||
| .slice(0, -snapshotExtension.length), | ||
|
|
||
| testPathForConsistencyCheck: 'foo/__tests__/bar.test.js', | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "jest": { | ||
| "testEnvironment": "node", | ||
| "snapshotResolver": "<rootDir>/customSnapshotResolver.js" | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.mjscan't be transformed at all -requireOrImportModulepicks the extension branch and hands off to nativeimport()before the hook exists. There's also notransformkey, no babel config and no deps here, and setting"transform": {}doesn't change the result.My bad for essentially asking you to copy the test in #12014 verbatim without reading it closer.
Give it an extension the pipeline can claim.
.ts, or.jswith ESM syntax and notype: module, both go throughrequire()and hit babel.Note that the current tests doesn't need the
yarn installthing. that might change dependening on how you do the transform ofc 🙂