RTECO-1362 - Add strict mode for npm build-info dependency resolution - #417
Closed
udaykb2 wants to merge 1 commit into
Closed
RTECO-1362 - Add strict mode for npm build-info dependency resolution#417udaykb2 wants to merge 1 commit into
udaykb2 wants to merge 1 commit into
Conversation
udaykb2
marked this pull request as draft
August 30, 2026 09:35
Introduce NpmTreeDepListParam.FailOnMissingDeps: when set, dependencies whose tarball can't be resolved from the npm cache cause CalculateNpmDependenciesList to return an error instead of only logging a warning and silently omitting them from the build-info. Peer/bundled/optional missing deps are unaffected and remain debug-only, since those are often expected (e.g. platform-specific optional deps). Add NpmModule.SetFailOnMissingDeps to thread the flag from CLI callers through to CalcDependencies.
udaykb2
force-pushed
the
RTECO-1362-npm-fail-on-missing-deps
branch
from
August 30, 2026 09:43
ed82935 to
a418385
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce NpmTreeDepListParam.FailOnMissingDeps: when set, dependencies whose tarball can't be resolved from the npm cache cause CalculateNpmDependenciesList to return an error instead of only logging a warning and silently omitting them from the build-info.
Peer/bundled/optional missing deps are unaffected and remain debug-only, since those are often expected (e.g. platform-specific optional deps).
Add NpmModule.SetFailOnMissingDeps to thread the flag from CLI callers through to CalcDependencies.