Gate the violation link on the minimum Xray version (XRAY-155957)

The violation permalink endpoint shipped in Xray 3.150.4 / 3.151.0
(XRAY-147005). Without a gate, Frogbot would print a link that 404s on
older Xray versions. GetViolationUiLinkBaseUrl returns an empty string
below the minimum, which the renderer already treats as "no link".

The endpoint was also backported to 3.143.31, but a single minimum
cannot cover that line without wrongly admitting 3.144-3.150.3.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: Jordanh1996

scanpullrequest/scanpullrequest.go

@@ -57,7 +57,7 @@ func (pr *ScanPullRequestCmd) Run(repository utils.Repository, client vcsclient.
 		return
 	}
 	if pullRequestIssues.IsFailPrRuleApplied() {
-		issues.LogFailingPolicyRulesForPr(pullRequestIssues.Violations, utils.GetPlatformUrl(&repository.Server))
+		issues.LogFailingPolicyRulesForPr(pullRequestIssues.Violations, utils.GetViolationUiLinkBaseUrl(&repository.Server, repository.Params.JFrogPlatform.XrayVersion))
 		err = errors.New(SecurityIssueFoundErr)
 		return
 	}

scanrepository/scanrepository.go

@@ -160,7 +160,7 @@ func (sr *ScanRepositoryCmd) scanAndFixBranch(repository *utils.Repository) (tot
 	defer func() {
 		// Always check policy even if an error occurred during the scan
 		if policyErr := policy.CheckPolicyFailBuildError(scanResults); policyErr != nil {
-			issues.LogFailingPolicyRulesForBuild(scanResults.Violations, utils.GetPlatformUrl(&repository.Server))
+			issues.LogFailingPolicyRulesForBuild(scanResults.Violations, utils.GetViolationUiLinkBaseUrl(&repository.Server, repository.Params.JFrogPlatform.XrayVersion))
 			err = errors.Join(err, policyErr)
 		}
 	}()

utils/getconfiguration.go

@@ -23,7 +23,10 @@ import (
 	"github.com/jfrog/jfrog-client-go/utils/log"
 )
 
-const configProfileV3MinXrayVersion = "3.117.0" // TODO switch to real the Xray version when available
+const (
+	configProfileV3MinXrayVersion = "3.117.0" // TODO switch to real the Xray version when available
+	violationUiLinkMinXrayVersion = "3.150.4"
+)
 
 type FrogbotDetails struct {
 	XrayVersion   string
@@ -223,8 +226,14 @@ func extractJFrogCredentialsFromEnvs() (*coreconfig.ServerDetails, error) {
 	return &server, nil
 }
 
-// GetPlatformUrl returns the JFrog platform base URL, deriving it from the Xray URL when only the service URLs are configured.
-func GetPlatformUrl(server *coreconfig.ServerDetails) string {
+// GetViolationUiLinkBaseUrl returns the platform base URL used to build violation UI links, deriving it from the
+// Xray URL when only the service URLs are configured. It returns an empty string on Xray versions that predate the
+// violation permalink endpoint, so that no unresolvable link is printed. The endpoint was also released in 3.143.31,
+// but a single minimum cannot cover that line without wrongly admitting the 3.144-3.150.3 versions that lack it.
+func GetViolationUiLinkBaseUrl(server *coreconfig.ServerDetails, xrayVersion string) string {
+	if err := clientutils.ValidateMinimumVersion(clientutils.Xray, xrayVersion, violationUiLinkMinXrayVersion); err != nil {
+		return ""
+	}
 	if server.Url != "" {
 		return strings.TrimSuffix(server.Url, "/")
 	}

utils/getconfiguration_test.go

@@ -444,31 +444,41 @@ func createMockVcsClient(t *testing.T, repoOwner, repoName string, withError boo
 	return mockVcsClient
 }
 
-func TestGetPlatformUrl(t *testing.T) {
+func TestGetViolationUiLinkBaseUrl(t *testing.T) {
 	testCases := []struct {
-		name     string
-		server   config.ServerDetails
-		expected string
+		name        string
+		server      config.ServerDetails
+		xrayVersion string
+		expected    string
 	}{
 		{
-			name:     "Platform url set",
-			server:   config.ServerDetails{Url: "https://acme.jfrog.io/"},
-			expected: "https://acme.jfrog.io",
+			name:        "Platform url set",
+			server:      config.ServerDetails{Url: "https://acme.jfrog.io/"},
+			xrayVersion: violationUiLinkMinXrayVersion,
+			expected:    "https://acme.jfrog.io",
 		},
 		{
-			name:     "Derived from xray url",
-			server:   config.ServerDetails{XrayUrl: "https://acme.jfrog.io/xray/"},
-			expected: "https://acme.jfrog.io",
+			name:        "Derived from xray url",
+			server:      config.ServerDetails{XrayUrl: "https://acme.jfrog.io/xray/"},
+			xrayVersion: "3.151.0",
+			expected:    "https://acme.jfrog.io",
 		},
 		{
-			name:     "No urls configured",
-			server:   config.ServerDetails{},
-			expected: "",
+			name:        "No urls configured",
+			server:      config.ServerDetails{},
+			xrayVersion: "3.151.0",
+			expected:    "",
+		},
+		{
+			name:        "Xray version below the permalink endpoint",
+			server:      config.ServerDetails{Url: "https://acme.jfrog.io/"},
+			xrayVersion: "3.150.2",
+			expected:    "",
 		},
 	}
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
-			assert.Equal(t, tc.expected, GetPlatformUrl(&tc.server))
+			assert.Equal(t, tc.expected, GetViolationUiLinkBaseUrl(&tc.server, tc.xrayVersion))
 		})
 	}
 }