Conversation
…cture (#633) - Add trigger-ado-pipeline.sh script and GitHub Actions workflows for automated sanity (Maven + BuildInfo) and OIDC end-to-end tests - Publish .vsix to a private Marketplace publisher during CI and verify the extension version propagates before triggering ADO pipelines - Inline Maven pom.xml to remove GitHub SAML dependency - Rename private-build tasks with E2E suffix to fix ADO ambiguity - Add Marketplace version check in jobs 2 and 3 to guard against stale builds
Jobs 2 and 3 were checking out the PR head branch to run buildScripts/trigger-ado-pipeline.sh. That script lives in the base branch (dev) as shared CI infrastructure, not in every PR branch. Switching the ref to github.event.pull_request.base.sha ensures the script is always present regardless of which PR is under test. Co-authored-by: Cursor <cursoragent@cursor.com>
Two bugs caused jobs 2 and 3 (sanity + OIDC) to silently never run: 1. The 'Publish .vsix to Marketplace' step in job 1 ran when ADO_E2E_MARKETPLACE_PAT was set and failed with 'version must increase' on re-runs (same run_number, same version). This caused job 1 to fail, which skipped jobs 2 and 3 entirely — they appeared 'removed' in the checks UI. 2. Jobs 2 and 3 checked out the PR head branch to run buildScripts/trigger-ado-pipeline.sh, but that script lives in the base branch (dev) as shared CI infrastructure. Fix: use github.event.pull_request.base.sha so the script is always present regardless of which PR branch is under test. The publish step is dropped entirely; uploading the .vsix to the Marketplace remains a manual step as documented in the job summary. Co-authored-by: Cursor <cursoragent@cursor.com>
The global 'e2e-plugin-tests' concurrency group caused new label-triggered runs to queue silently behind any in-progress run from another PR. A queued workflow does not appear in the PR checks list until it actually starts, making it look like the pipeline was not triggered at all. Scope the group to the PR number so each PR gets its own concurrency slot. Also switch cancel-in-progress to true so re-triggering on the same PR (remove + re-add label) cancels the previous run immediately. Co-authored-by: Cursor <cursoragent@cursor.com>
retry pipeline trigger on transient 'task is missing' 400
Brings the post-2026-04-30 non-e2e product work onto v2 so the release pipeline can build and publish the new version: - #638: authenticate JFrog CLI download for OIDC service connections (JFrogToolsInstaller) - Default JFrog CLI 2.111.0 / pluginVersion 2.14.2 - Node 22 in the test matrix (RTECO-813) Also aligns e2e-plugin-tests.yml and trigger-ado-pipeline.sh with dev so the release step `git merge origin/dev` is conflict-free. No change to extension task runtime behavior beyond the items above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run formatfor formatting the code before submitting the pull request.