RTECO-1777 - Fix install & update's --version related issue

[udaykb2]

• All tests have passed. If this feature is not already covered by the tests, new tests have been added.
• The pull request is targeting the master branch.
• The code has been validated to compile successfully by running go vet ./....
• The code has been formatted properly using go fmt ./....

Summary

Fix three critical issues in Agent skills and plugins version resolution:

1. Panic in Non-TTY Environments: Prevented 'device not configured' panic in CI/CD by adding terminal detection before prompting
2. Missing Versions: Switched from filtered Skills API to raw storage API, exposing all versions (346 instead of ~180), including rtaut/rtdev builds
3. Ambiguous 404 Errors: Added error disambiguation to distinguish between missing repositories and missing skills/plugins

All fixes are applied at the source functions, so every downstream command (install, update, list, publish, delete) benefits universally.

Changes

Issue 1: Panic in Non-TTY Environments (CI/CD)

Problem: Commands crashed with 'device not configured' panic when stdin is not a terminal (CI/CD pipelines, Docker, piped scripts).

Solution:

• Added isStdinTerminal() check in agent/common/interactive.go to detect terminal availability
• Enhanced IsNonInteractive() to check stdin, stdout, and CI environment variable
• Both SelectPackageVersion() and ResolveRepo() now check terminal status before prompting

Result: All commands fail gracefully with a user-friendly error instead of panicking in non-interactive environments.

Issue 2: Server-Side Filtering Excluded Versions

Problem: Skills API returned only ~180 versions (filtered server-side); 346 total versions existed. rtaut/rtdev builds were invisible.

Solution:

• Changed ListVersions() in agent/skills/common/skills_api.go to query raw Artifactory storage API (FolderInfo) instead of filtered /api/v3/skills endpoint
• Directly reads version directories from filesystem without server-side filtering

Result: All 346 skill versions now visible; rtaut and rtdev builds accessible via install/update commands.

Issue 3: Ambiguous 404 Errors

Problem: 404 errors didn't distinguish between missing repositories and missing skills/plugins, breaking automation and confusing users.

Solution:

• Implemented IsHTTPNotFound() and DisambiguateFolderError() helpers in agent/common/versions.go
• When skill/plugin lookup fails with 404, immediately probe for repository existence
• Returns contextual error based on what's actually missing

Result: Clear error messages enable better debugging and automation.

Error Messages:

• "repository 'my-repo' not found" — when repository doesn't exist
• "skill 'my-skill' not found in repository 'my-repo'" — when skill/plugin is missing

Files Modified

• agent/common/interactive.go — Terminal detection with mocking support
• agent/common/select_version.go — Version selection safety check
• agent/common/resolve_repo.go — Repo resolution safety check
• agent/common/versions.go — HTTP status code parsing and 404 disambiguation logic
• agent/skills/common/skills_api.go — Raw storage API query, error disambiguation
• agent/skills/common/skills_util.go — Updated to use new ListVersions behavior
• agent/plugins/common/versions.go — Error disambiguation for plugins

Testing

TTY Panic Fix

# Should fail gracefully, not panic
echo "test" | jf skills install rtaut

# Should work without panic in CI
CI=true jf skills update

- [x] All [tests](https://github.com/jfrog/jfrog-cli-core#tests) passed. If this feature is not already covered by the tests, I added new tests.
- [x] All [static analysis checks](https://github.com/jfrog/jfrog-cli-core/actions/workflows/analysis.yml) passed.
- [x] Appropriate label is added to auto generate release notes.
- [x] I used gofmt for formatting the code before submitting the pull request.
- [x] PR description is clear and concise, and it includes the proposed solution/fix.
-----


<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit

- **Bug Fixes**
  - Improved error messages when repositories, plugins, skills, or versions are missing.
  - Version listings now validate inputs and correctly distinguish missing repositories from missing content.
  - Improved version checks for skills and plugins.

- **User Experience**
  - Improved detection of interactive versus non-interactive terminal sessions, including CI environments.

- **Tests**
  - Expanded coverage for repository and content-not-found scenarios and terminal detection behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

Version listing now validates inputs, reads storage folders, and distinguishes missing repositories from missing plugins or skills. Interactive detection now checks both standard input and output terminal status, with expanded test coverage.

Changes

Version resolution

Layer / File(s)	Summary
Folder error disambiguation agent/common/versions.go, agent/common/versions_test.go	Adds shared handling that probes repository existence after a folder 404 and returns repository-specific or folder-specific errors.
Plugin version not-found handling agent/plugins/common/versions.go	Trims and validates inputs, centralizes 404 disambiguation, and wraps listing failures.
Skill version listing and existence checks agent/skills/common/skills_api.go, agent/skills/common/skills_util.go	Lists skill versions from raw storage folders, validates inputs, distinguishes 404 cases, and checks version existence through listed versions.

Interactive detection

Layer / File(s)	Summary
Non-interactive terminal detection agent/common/interactive.go, agent/common/interactive_test.go, agent/plugins/commands/publish/publish_test.go	Adds mockable stdin terminal detection. IsNonInteractive checks CI, stdout, and stdin terminal status. Tests cover terminal combinations and restore detector state.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Suggested reviewers: itsmeleela, agrasth

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 42.86% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: fixing version-related issues in install and update commands.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch RTECO-1777-jf-skills-version-issue

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@agent/common/select_version.go`:
- Around line 23-32: Replace the os.ModeCharDevice test in hasStdinTTY with a
real terminal-specific TTY check, preserving false on stat/check errors so
non-interactive stdin cannot reach go-prompt. Apply the same corrected check at
agent/common/select_version.go line 42 and agent/common/resolve_repo.go line 52;
update agent/common/interactive.go only if it contains the equivalent stdin
check.

In `@agent/plugins/common/versions.go`:
- Around line 36-42: Propagate non-404 errors from the repository probe instead
of reporting missing resources. In agent/plugins/common/versions.go lines 36-42,
update the FolderInfo handling to return or wrap repoErr for non-404 failures,
and only return ErrPluginNotFoundInRepo after a successful probe; apply the
equivalent change to the skill-not-found flow in
agent/skills/common/skills_api.go lines 60-65, preserving the existing 404
behavior.

In `@agent/skills/common/skills_api.go`:
- Around line 42-55: Add a trimmed slug validation in ListVersions before
CreateServiceManager, returning an appropriate error when the skill name is
empty. Preserve the existing repository validation and ensure the storage lookup
only runs with a non-empty skill slug.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3ce3eaf3-dfae-41fd-ad64-1ee67cc0dff3

📥 Commits

Reviewing files that changed from the base of the PR and between 1a5e6a2 and 9613a60.

📒 Files selected for processing (5)

• agent/common/resolve_repo.go
• agent/common/select_version.go
• agent/plugins/common/versions.go
• agent/skills/common/skills_api.go
• agent/skills/common/skills_util.go

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
@.worktrees/task-RTECO-1648/task/RTECO-1648/rteco-1648-jf-agent-apm-implementation-document:
- Line 1: Update buildSourcesLine and the surrounding setup/command flow to
validate serverDetails.GetArtifactoryUrl() before credentials are appended or
the APT source is generated. Reject non-HTTPS URLs by default, allowing HTTP
only for an explicitly recognized local test endpoint, and preserve source
generation only after validation succeeds.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: de3e855d-cf52-4c57-9392-d3c9f3e28319

📥 Commits

Reviewing files that changed from the base of the PR and between 9613a60 and dfc79e4.

📒 Files selected for processing (6)

• .worktrees/task-RTECO-1648/task/RTECO-1648/rteco-1648-jf-agent-apm-implementation-document
• .worktrees/task-RTFACT-31140/task/RTFACT-31140/gradle-buildsrc-support
• agent/common/interactive.go
• agent/plugins/common/versions.go
• agent/skills/common/skills_api.go
• artifactory/commands/testdata/jfrog-cli.conf.v6

🚧 Files skipped from review as they are similar to previous changes (2)

• agent/skills/common/skills_api.go
• agent/plugins/common/versions.go