Skip to content

Feat: Implement Update and Import for Access v2 API based LDAP groups in Artifactory - #1377

Open
joshuaauger wants to merge 5 commits into
jfrog:masterfrom
joshuaauger:feature/ldap-refresh
Open

Feat: Implement Update and Import for Access v2 API based LDAP groups in Artifactory#1377
joshuaauger wants to merge 5 commits into
jfrog:masterfrom
joshuaauger:feature/ldap-refresh

Conversation

@joshuaauger

Copy link
Copy Markdown

Disclosure: This pull request includes code written with the assistance of AI (e.g., GitHub Copilot, ChatGPT).

This pull request adds support for configuring the refresh_operation for the artifactory_ldap_group_setting_v2 resource, allowing users to specify how LDAP groups are refreshed after creation or update. The change introduces a new optional attribute, ensures the operation is performed after resource changes, and updates documentation and examples accordingly.

LDAP Group Refresh Operation Support:

  • Added a new optional refresh_operation attribute (with valid values UPDATE, IMPORT, or UPDATE_AND_IMPORT, defaulting to UPDATE_AND_IMPORT) to the artifactory_ldap_group_setting_v2 resource schema. This allows users to control how LDAP groups are refreshed after create or update actions. [1] [2]
  • Updated the resource's Create and Update logic to trigger the appropriate LDAP group refresh operation by calling the relevant Artifactory API endpoint with the selected operation. [1] [2] [3] [4]
  • Ensured the refresh_operation value is preserved in Terraform state, since the Artifactory API does not return this field.

Documentation and Example Updates:

  • Updated the documentation (docs/resources/ldap_group_setting_v2.md) to describe the new refresh_operation attribute and its usage. [1] [2]
  • Updated the example resource configuration to include the refresh_operation attribute.

@github-actions

github-actions Bot commented Feb 17, 2026

Copy link
Copy Markdown

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@joshuaauger

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@srinivasgowda097

Copy link
Copy Markdown
Member

@joshuaauger update the changelog for the changes to trigger the acceptance tests

@vikramreddym
vikramreddym force-pushed the feature/ldap-refresh branch from ec91e4e to 5238142 Compare March 19, 2026 18:31
@joshuaauger

Copy link
Copy Markdown
Author

@srinivasgowda097, @vikramreddym updated the changelog, would you be able to review and approve now?

@soumyas-dev

Copy link
Copy Markdown
Collaborator

Hi @joshuaauger ,

Thank you for your contribution.

Our CI pipeline issues have been resolved, and we are now accepting contributions again. If you are still interested in submitting this change, please rebase your branch on master and update the CHANGELOG. We look forward to reviewing your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants