Skip to content

fix: default missing webhook anyFederated field - #1415

Open
omribz156 wants to merge 1 commit into
jfrog:masterfrom
omribz156:codex/webhook-any-federated-default
Open

fix: default missing webhook anyFederated field#1415
omribz156 wants to merge 1 commit into
jfrog:masterfrom
omribz156:codex/webhook-any-federated-default

Conversation

@omribz156

Copy link
Copy Markdown

Summary

Verification

  • go test ./pkg/artifactory/resource/webhook -run TestFromRepoCriteriaAPIModelDefaultsMissingAnyFederatedToFalse -count=1
  • go test ./pkg/artifactory/resource/webhook -count=1
  • git diff --check

This was implemented with Codex assistance, with the final diff manually reviewed and kept focused on the missing-field panic.

Closes #1412.

@omribz156
omribz156 requested a review from vasukinjfrog as a code owner June 10, 2026 20:19
@omribz156

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@soumyas-dev

Copy link
Copy Markdown
Collaborator

Hi @omribz156 ,

Thank you for your contribution.

Our CI pipeline issues have been resolved, and we are now accepting contributions again. If you are still interested in submitting this change, please rebase your branch on master and update the CHANGELOG. We look forward to reviewing your pull request.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 59 minutes.

View limit details

Limit details: You’ve used all 2 included reviews currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7af87060-d0bd-4df8-a879-b00a771540ca

📥 Commits

Reviewing files that changed from the base of the PR and between dcb2bea and 66749c5.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • pkg/artifactory/resource/webhook/resource_artifactory_webhook_repo.go
  • pkg/artifactory/resource/webhook/resource_artifactory_webhook_repo_unit_test.go

Comment @coderabbitai help to get the list of available commands.

@omribz156

Copy link
Copy Markdown
Author

Rebased on current master and retained the CHANGELOG entry. Verified with go test ./pkg/artifactory/resource/webhook -count=1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

missing anyFederated causes panic when reading webhook info

2 participants