fix: default missing webhook anyFederated field - #1415
Conversation
|
I have read the CLA Document and I hereby sign the CLA |
|
Hi @omribz156 , Thank you for your contribution. Our CI pipeline issues have been resolved, and we are now accepting contributions again. If you are still interested in submitting this change, please rebase your branch on master and update the CHANGELOG. We look forward to reviewing your pull request. |
6a659b4 to
66749c5
Compare
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used all 2 included reviews currently available. This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Comment |
|
Rebased on current master and retained the CHANGELOG entry. Verified with go test ./pkg/artifactory/resource/webhook -count=1. |
Summary
anyFederatedAPI field tofalsewhile reading repo webhook criteriaanyFederatedVerification
go test ./pkg/artifactory/resource/webhook -run TestFromRepoCriteriaAPIModelDefaultsMissingAnyFederatedToFalse -count=1go test ./pkg/artifactory/resource/webhook -count=1git diff --checkThis was implemented with Codex assistance, with the final diff manually reviewed and kept focused on the missing-field panic.
Closes #1412.