Skip to content

MLD-1384- VS code rewrite mcp.json - #55

Merged
arielamitjfrog merged 5 commits into
mainfrom
feature/MLD-1384-vscode-rewrite-mcp-json
Aug 25, 2026
Merged

MLD-1384- VS code rewrite mcp.json#55
arielamitjfrog merged 5 commits into
mainfrom
feature/MLD-1384-vscode-rewrite-mcp-json

Conversation

@arielamitjfrog

@arielamitjfrog arielamitjfrog commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a Copilot SessionStart hook that discovers plugin-owned mcp.json / .mcp.json files and runs Agent Guard’s --rewrite-mcp-json pipeline so installed plugins’ MCP server commands are policy-governed.
  • Discovery is VS Code–specific: Copilot installed-plugins trees, ~/.vscode/agent-plugins, and this plugin’s own configs. User Code/User/mcp.json and workspace .vscode/mcp.json are never rewritten (including via symlink / override-root escape).
  • The hook is fail-open (60s timeout). If any discovered file actually changes, Copilot is told to run Developer: Reload Window so rewritten MCP servers reconnect.
  • Pins vendored plugin/modules/ to jfrog-agent-hooks v0.11.0 (shared rewrite pipeline plus package-resolution onboarding modules). @jfrog/agent-guard stays an npx runtime fetch (default pin 1.6.0), not a vendored copy.
  • Documents the feature in README.md / VENDOR.md, bumps the plugin to 1.0.18, and covers discovery + SessionStart behavior with unit tests.

@arielamitjfrog
arielamitjfrog requested a review from a team as a code owner August 19, 2026 12:32
Co-authored-by: Cursor <cursoragent@cursor.com>
@arielamitjfrog
arielamitjfrog force-pushed the feature/MLD-1384-vscode-rewrite-mcp-json branch from b53feca to 9c5a5e0 Compare August 24, 2026 07:00

@YoniMelki YoniMelki left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address the inline comments on discovery, vendor docs, and the SessionStart path.

Comment thread plugin/scripts/vscode-mcp-json-discover.mjs
Comment thread plugin/scripts/vscode-mcp-json-discover.mjs Outdated
Comment thread VENDOR.md Outdated
Comment thread plugin/scripts/vscode-mcp-json-discover.mjs Outdated
Comment thread plugin/scripts/vscode-mcp-json-discover.mjs Outdated
Comment thread plugin/scripts/vscode-align-mcp-json.mjs
Comment thread plugin/scripts/vscode-mcp-json-discover.mjs Outdated
@arielamitjfrog
arielamitjfrog merged commit 67d0183 into main Aug 25, 2026
3 checks passed
@arielamitjfrog
arielamitjfrog deleted the feature/MLD-1384-vscode-rewrite-mcp-json branch August 25, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants