Repository navigation
Commit 059afcb
committed
Fix PaintHarness after rebase: paint from the fragment tree, not deleted CssBox.Paint
PR ArthurHub#262's PaintHarness.PaintBox (merged into master while this branch was in
flight) called box.Paint(g) directly - the old live-tree paint entry point.
This branch's own F3 stage later deleted CssBox.Paint/PaintImp entirely once
FragmentPainter became the sole paint path, so rebasing this branch onto
master (which now carries PaintHarness) fails to compile: git's line-based
merge can't catch an API a fresh commit calls having been removed by an
earlier one in this branch's own history.
Fix: PaintHarness.PaintBox now locates the CssBox's own BoxFragment in
container.FragmentTree (searching every fragmentainer, in case the box was
relocated onto a later page) and paints it via a new FragmentPainter test
entry point, FragmentPainter.PaintFragmentSubtree - a thin wrapper that sets
the painter's band-top before delegating to its existing private PaintFragment,
letting a test get "just this box's draw calls" without duplicating the real
paint walk. This is the same widen-for-test-use precedent already applied to
CssBox.PaintBackground/PaintWord/PaintDecoration.
Full three-project suite passes after the rebase: HtmlRenderer.Test (2367),
HtmlRenderer.IntegrationTest (146), HtmlRenderer.PdfSharp.Test (30) - 0 failed.1 parent 1be6c4f commit 059afcb
2 files changed
Lines changed: 53 additions & 1 deletion
File tree
- Source
- HtmlRenderer/Core/Paint
- Test/HtmlRenderer.IntegrationTest/TestSupport
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
126 | 139 | | |
127 | 140 | | |
128 | 141 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
4 | 6 | | |
5 | 7 | | |
6 | 8 | | |
| |||
68 | 70 | | |
69 | 71 | | |
70 | 72 | | |
71 | | - | |
| 73 | + | |
| 74 | + | |
72 | 75 | | |
73 | 76 | | |
74 | 77 | | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
75 | 114 | | |
0 commit comments