bump curl to 8.19.0 - #49
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on upgrading the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the vendored libcurl library from version 8.18.0 to 8.19.0. This involves updating the version number in README.org, modifying the curl dependency URL and hash in build.zig.zon, and adjusting the source file paths in libs/curl.zig to reflect changes in the libcurl source structure, specifically moving strdup.c and adding basename.c and snprintf.c under lib/curlx/. There are no review comments to address.
There was a problem hiding this comment.
Pull request overview
Bumps the vendored libcurl dependency to 8.19.0 and aligns the build inputs/docs so the package continues to build and accurately report its bundled curl version.
Changes:
- Update
build.zig.zoncurl dependency URL + hash to curl 8.19.0. - Adjust
libs/curl.zigC source list for upstream file layout/requirements (movestrdup.c, add newcurlxsources). - Update README to reflect the new vendored libcurl version/link.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| libs/curl.zig | Updates the manually maintained libcurl C source file list to match curl 8.19.0 layout. |
| build.zig.zon | Bumps the fetched curl tarball URL and Zig package hash to 8.19.0. |
| README.org | Updates documented vendored libcurl version/link to 8.19.0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks! |
bump version of curl to 8.19.0