Skip to content

Commit 4ab4207

Browse files
Improved testing of logged errors
1 parent 7f9947f commit 4ab4207

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

tests/test_error.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ def test_LogMsg(self):
3737
self.check_result(
3838
exiv2.LogMsg.level(), exiv2.LogMsg.Level, exiv2.LogMsg.Level.debug)
3939
# get exiv2 to log a message
40-
with self.assertLogs(level=logging.WARNING):
40+
with self.assertLogs('exiv2', logging.WARNING):
4141
comment = exiv2.CommentValue('charset=invalid Fred')
4242
# test setting and clearing handler
4343
self.assertEqual(exiv2.LogMsg.handler(), exiv2.pythonHandler)

tests/test_types.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,10 +155,10 @@ def test_localisation(self):
155155
# test localisation
156156
self.check_result(exiv2.exvGettext(str_en), str, str_de)
157157
if exiv2.testVersion(0, 28, 3) or not exiv2.testVersion(0, 28, 0):
158-
with self.assertLogs(level=logging.WARNING) as cm:
158+
with self.assertLogs('exiv2', logging.WARNING) as cm:
159159
comment = exiv2.CommentValue('charset=invalid Fred')
160-
self.assertEqual(cm.output, [
161-
'WARNING:exiv2:Ungültiger Zeichensatz: "invalid"'])
160+
self.assertIn('WARNING:exiv2:Ungültiger Zeichensatz: "invalid"',
161+
cm.output)
162162
with self.assertRaises(exiv2.Exiv2Error) as cm:
163163
key = exiv2.ExifKey(999, 'Invalid')
164164
self.assertEqual(cm.exception.message.replace('"', "'"),

0 commit comments

Comments
 (0)