Use := where possible

Author: jimporter

bfg9000/backends/msbuild/syntax.py

@@ -263,8 +263,7 @@ def basename(path):
             name = i['name']
             c = func(name, i['options'])
 
-            prefix = prefixes[basename(name.path)]
-            if prefix:
+            if prefix := prefixes[basename(name.path)]:
                 # If this prefix is shared with another file, strip it out to
                 # create a unique directory to store this object file.
                 suffix = path.Path(name.path.relpath(prefix)).stripext('.obj')

bfg9000/builtins/compile.py

@@ -289,8 +289,7 @@ def _get_flags(backend, rule, build_inputs, buildfile):
             buildfile
         )
         cmd_kwargs['flags'] = cflags
-        flags = rule.flags(gopts)
-        if flags:
+        if flags := rule.flags(gopts):
             variables[cflags] = [global_cflags] + flags
 
     return variables, cmd_kwargs

bfg9000/builtins/copy_file.py

@@ -29,8 +29,7 @@ def __init__(self, context, output, file, *, mode='copy', extra_deps=None,
 
     @staticmethod
     def convert_args(context, name, file, kwargs):
-        directory = kwargs.pop('directory', None)
-        if directory:
+        if directory := kwargs.pop('directory', None):
             directory = buildpath(context, directory, strict=True)
         file = context['auto_file'](file)
 

bfg9000/builtins/link.py

@@ -125,8 +125,7 @@ def _get_linkers(self, env, langs):
         yielded = False
         for i in langs:
             try:
-                linker = env.builder(i).linker(self.mode)
-                if linker:
+                if linker := env.builder(i).linker(self.mode):
                     yielded = True
                     yield linker
             except ToolNotFoundError:
@@ -420,8 +419,7 @@ def _get_flags(backend, rule, build_inputs, buildfile):
             buildfile
         )
         cmd_kwargs['flags'] = ldflags
-        flags = rule.flags(gopts)
-        if flags:
+        if flags := rule.flags(gopts):
             variables[ldflags] = [global_ldflags] + flags
 
     if hasattr(linker, 'libs_var'):
@@ -431,8 +429,7 @@ def _get_flags(backend, rule, build_inputs, buildfile):
             buildfile
         )
         cmd_kwargs['libs'] = ldlibs
-        lib_flags = rule.lib_flags(gopts)
-        if lib_flags:
+        if lib_flags := rule.lib_flags(gopts):
             variables[ldlibs] = [global_ldlibs] + lib_flags
 
     if hasattr(rule, 'manifest'):

bfg9000/environment.py

@@ -230,8 +230,7 @@ def run_arguments(self, args, lang=None):
 
         if lang is None:
             lang = first(getattr(args[0], 'lang', None), default=None)
-        runner = self._runner(lang)
-        if runner:
+        if runner := self._runner(lang):
             return runner.run_arguments(args[0]) + args[1:]
 
         if not isinstance(args[0], Executable):

bfg9000/options.py

@@ -102,8 +102,7 @@ def __repr__(self):
     def recurse(cls, libs):
         def do_recurse(result, libs):
             for i in libs:
-                forward_opts = getattr(i, 'forward_opts', None)
-                if forward_opts:
+                if forward_opts := getattr(i, 'forward_opts', None):
                     result.update(forward_opts)
                     do_recurse(result, forward_opts.libs)
 
@@ -121,8 +120,7 @@ def _get_ns_annotations(attrs):
 
     if sys.version_info >= (3, 14):
         import annotationlib
-        annotate = annotationlib.get_annotate_from_class_namespace(attrs)
-        if annotate:
+        if annotate := annotationlib.get_annotate_from_class_namespace(attrs):
             return annotationlib.call_annotate_function(
                 annotate, format=annotationlib.Format.FORWARDREF
             )

bfg9000/packages.py

@@ -24,8 +24,7 @@ class Package:
     is_package = True
 
     def __init__(self, name, submodules=None, *, format, deps=None):
-        submodules = _listify(submodules)
-        if submodules:
+        if submodules := _listify(submodules):
             name = '{}[{}]'.format(name, ','.join(submodules))
 
         self.name = name

bfg9000/shell/__init__.py

@@ -33,8 +33,7 @@ def __str__(self):
                    .format(cmd, self.returncode))
 
         if self.stderr:
-            stderr = self.stderr.strip()
-            if stderr:
+            if stderr := self.stderr.strip():
                 msg += ':\n' + textwrap.indent(stderr, ' ' * 2)
         return msg
 
@@ -76,8 +75,7 @@ def which(names, path=default_sentinel, pathext=default_sentinel, *,
     if pathext is default_sentinel:
         pathext = ['']
         if platform_info().has_path_ext:
-            extstr = env.get('PATHEXT')
-            if extstr:
+            if extstr := env.get('PATHEXT'):
                 pathext.extend(split_paths(extstr))
 
     for name in names:

bfg9000/tools/c_family.py

@@ -98,8 +98,7 @@ def c_family_builder(env, lang):
         fallback = _fallback_posix_builder
 
     langinfo = known_langs[lang]
-    cmd = env.getvar(langinfo.var('compiler'))
-    if cmd:
+    if cmd := env.getvar(langinfo.var('compiler')):
         return choose_builder(env, langinfo, _builders, candidates=cmd,
                               fallback_builder=fallback)
 

bfg9000/tools/cc/__init__.py

@@ -32,8 +32,7 @@ def __init__(self, env, langinfo, command, found, version_output):
         # Try to infer the appropriate -fuse-ld option from the LD environment
         # variable.
         link_command = command[:]
-        ld_command = env.getvar(ldinfo.var('linker'))
-        if ld_command:
+        if ld_command := env.getvar(ldinfo.var('linker')):
             tail = os.path.splitext(ld_command)[1][1:]
             if tail in ['bfd', 'gold']:
                 log.info('setting `-fuse-ld={}` for `{}`'