refactor(gitcommit): migrate git commands to arrays

Replace string shell commands and redirects with arrays in git.lua
and command.lua. Replace vim.fn.system with CommandExecutor and
replace vim.loop with vim.uv.

Author: jinzhongjia

lua/codecompanion/_extensions/gitcommit/git.lua

@@ -58,8 +58,7 @@ function Git.is_repository()
     check_dir = parent
   end
 
-  local redirect = (vim.uv.os_uname().sysname == "Windows_NT") and " 2>nul" or " 2>/dev/null"
-  local cmd = "git rev-parse --is-inside-work-tree" .. redirect
+  local cmd = { "git", "rev-parse", "--is-inside-work-tree" }
   local result = vim.fn.system(cmd)
   local is_repo = vim.v.shell_error == 0 and vim.trim(result) == "true"
 
@@ -85,8 +84,7 @@ function Git.is_amending()
       return false
     end
 
-    local redirect = (vim.uv.os_uname().sysname == "Windows_NT") and " 2>nul" or " 2>/dev/null"
-    vim.fn.system("git rev-parse --verify HEAD" .. redirect)
+    vim.fn.system({ "git", "rev-parse", "--verify", "HEAD" })
     if vim.v.shell_error ~= 0 then
       return false
     end

lua/codecompanion/_extensions/gitcommit/git_utils.lua

@@ -217,7 +217,7 @@ end
 ---Check if running on Windows
 ---@return boolean
 function M.is_windows()
-  return vim.loop.os_uname().sysname == "Windows_NT"
+  return vim.uv.os_uname().sysname == "Windows_NT"
 end
 
 ---Quote a string for shell command (cross-platform)

lua/codecompanion/_extensions/gitcommit/tools/ai_release_notes.lua

@@ -1,6 +1,8 @@
 local prompts = require("codecompanion._extensions.gitcommit.prompts.release_notes")
 local git_utils = require("codecompanion._extensions.gitcommit.git_utils")
+local Command = require("codecompanion._extensions.gitcommit.tools.command")
 
+local CommandExecutor = Command.CommandExecutor
 local shell_quote = git_utils.shell_quote
 
 ---@class CodeCompanion.GitCommit.Tools.AIReleaseNotes: CodeCompanion.Tools.Tool
@@ -51,7 +53,9 @@ Output styles:
 - changelog: Developer-focused changelog format
 - marketing: User-friendly marketing release notes]]
 
--- Helper function to get commit details with diffs
+---@param from_ref string Starting reference (tag or commit hash)
+---@param to_ref string Ending reference (tag or commit hash or HEAD)
+---@return table|nil, string|nil Commits array and error message
 local function get_detailed_commits(from_ref, to_ref)
   -- Git range A..B = commits reachable from B but not from A
   -- This correctly excludes from_ref itself and includes up to to_ref
@@ -63,8 +67,8 @@ local function get_detailed_commits(from_ref, to_ref)
   local format_str = shell_quote("%H||%s||%an||%b" .. separator)
   local commit_cmd = string.format("git log --pretty=format:%s %s", format_str, escaped_range)
 
-  local success, output = pcall(vim.fn.system, commit_cmd)
-  if not success or vim.v.shell_error ~= 0 then
+  local success, output = CommandExecutor.run(commit_cmd)
+  if not success then
     return nil, "Failed to get commit history"
   end
 
@@ -79,12 +83,12 @@ local function get_detailed_commits(from_ref, to_ref)
 
   for _, entry in ipairs(commit_entries) do
     if entry and vim.trim(entry) ~= "" then
-      -- Find the first non-empty line with commit info
+      -- Find first non-empty line with commit info
       local lines = vim.split(entry, "\n")
       local commit_line = nil
       local body_start_idx = 1
 
-      -- Find the line with the commit info (has || separators)
+      -- Find line with commit info (has || separators)
       for i, line in ipairs(lines) do
         if line:match("||") then
           commit_line = line
@@ -145,8 +149,8 @@ AIReleaseNotes.cmds = {
     -- Get tags if not specified
     if not to_tag or not from_tag then
       -- Try to get tags sorted by version
-      local success, tags_output = pcall(vim.fn.system, "git tag --sort=-version:refname")
-      if success and vim.v.shell_error == 0 and tags_output and vim.trim(tags_output) ~= "" then
+      local success, tags_output = CommandExecutor.run("git tag --sort=-version:refname")
+      if success and tags_output and vim.trim(tags_output) ~= "" then
         local tags = {}
         for tag in tags_output:gmatch("[^\r\n]+") do
           local trimmed = vim.trim(tag)
@@ -171,8 +175,8 @@ AIReleaseNotes.cmds = {
           elseif #tags == 1 then
             -- Only one tag, get first commit as starting point
             local first_commit_cmd = "git rev-list --max-parents=0 HEAD"
-            local fc_success, first_commit_output = pcall(vim.fn.system, first_commit_cmd)
-            if fc_success and vim.v.shell_error == 0 then
+            local fc_success, first_commit_output = CommandExecutor.run(first_commit_cmd)
+            if fc_success and first_commit_output and vim.trim(first_commit_output) ~= "" then
               from_tag = vim.trim(first_commit_output):sub(1, 8)
             else
               -- Fallback to 10 commits ago

lua/codecompanion/_extensions/gitcommit/tools/command.lua

@@ -523,10 +523,15 @@ function CommandBuilder.pull(remote, branch, rebase)
 end
 
 ---Build git rev-parse command (check repo)
----@return string command
+---@return string[] command array
 function CommandBuilder.is_inside_work_tree()
-  local redirect = is_windows() and " 2>nul" or " 2>/dev/null"
-  return "git rev-parse --is-inside-work-tree" .. redirect
+  return { "git", "rev-parse", "--is-inside-work-tree" }
+end
+
+---Build git rev-parse --verify HEAD command
+---@return string[] command array
+function CommandBuilder.verify_head()
+  return { "git", "rev-parse", "--verify", "HEAD" }
 end
 
 ---Build git rev-parse git-dir command
@@ -631,8 +636,8 @@ end
 ---@return boolean
 function CommandExecutor.is_git_repo()
   local cmd = CommandBuilder.is_inside_work_tree()
-  local ok, output = pcall(vim.fn.system, cmd)
-  return ok and vim.v.shell_error == 0 and vim.trim(output) == "true"
+  local ok, result = CommandExecutor.run_array(cmd)
+  return ok and vim.trim(result) == "true"
 end
 
 ---Execute a git command with repo check

tests/test_command_builder.lua

@@ -714,7 +714,15 @@ T["utility"]["is_inside_work_tree"] = function()
     local Command = require("codecompanion._extensions.gitcommit.tools.command")
     return Command.CommandBuilder.is_inside_work_tree()
   ]])
-  h.eq(true, result:find("git rev%-parse %-%-is%-inside%-work%-tree") ~= nil)
+  h.eq({ "git", "rev-parse", "--is-inside-work-tree" }, result)
+end
+
+T["utility"]["verify_head"] = function()
+  local result = child.lua([[
+    local Command = require("codecompanion._extensions.gitcommit.tools.command")
+    return Command.CommandBuilder.verify_head()
+  ]])
+  h.eq({ "git", "rev-parse", "--verify", "HEAD" }, result)
 end
 
 T["utility"]["git_dir"] = function()