Repository navigation
Commit 22fe6fc
committed
Preserve per-row ids in the SaveAutoIncrement std::vector overload
The std::vector compatibility wrapper copied into an fcpp::vector, ran the
whole batch, then copied ids back at the end. Because each insert commits
independently, a later row throwing would skip the end copy-back and leave
the caller's std::vector without ids for rows that already committed.
Save each record through the single-record overload instead, writing every
id back as soon as its row is inserted - restoring the pre-fcpp::vector
partial-success behavior and dropping the container copy.
Addresses a Codex review comment on PR #39.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YLXHcZjrnrdhRZAgqDh6kd1 parent 9c28890 commit 22fe6fc
1 file changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
154 | | - | |
155 | | - | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
156 | 158 | | |
157 | 159 | | |
158 | | - | |
159 | | - | |
160 | | - | |
161 | | - | |
| 160 | + | |
| 161 | + | |
162 | 162 | | |
163 | 163 | | |
164 | 164 | | |
| |||
0 commit comments