Skip to content

Commit 535409f

Browse files
committed
Rename the unicode files to match UnicodeTranscoder (#25)
Follow-up to the class rename, keeping the one-file-per-class naming the rest of src/ uses (string_utilities.cc holds StringUtilities). - src/internal/unicode.h -> src/internal/unicode_transcoder.h - src/unicode.cc -> src/unicode_transcoder.cc - tests/unicode_test.cc -> tests/unicode_transcoder_test.cc The three includes and one comment reference follow. Both CMakeLists collect sources by glob, so neither needed an edit. The gtest suite names are deliberately left alone: UnicodeCoreTest exercises the transcoder directly, but UnicodeTest goes through StringUtilities::ToUtf8/FromUtf8, so naming it after the class would describe the wrong unit. Verified locally on Linux GCC at C++11 and C++20, both configured from scratch so the globs were re-evaluated: 124/124 tests pass in both, clang-format clean on the changed files. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YLXHcZjrnrdhRZAgqDh6kd
1 parent 1fd1d8b commit 535409f

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

‎src/string_utilities.cc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424

2525
#include <numeric>
2626

27-
#include "internal/unicode.h"
27+
#include "internal/unicode_transcoder.h"
2828

2929
using namespace sqlite_reflection;
3030

@@ -46,7 +46,7 @@ To cast_each(const From& source) {
4646
// wchar_t holds UTF-16 code units where it is 16 bits wide (Windows) and Unicode code points
4747
// where it is 32 bits wide (Linux, macOS). Selecting the path by width is what keeps text above
4848
// U+FFFF identical across platforms; a single facet cannot serve both, which is the defect this
49-
// replaced. See internal/unicode.h.
49+
// replaced. See internal/unicode_transcoder.h.
5050
template <size_t WideCharSize>
5151
struct WideCodec;
5252

src/unicode.cc renamed to src/unicode_transcoder.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
2121
// SOFTWARE.
2222

23-
#include "internal/unicode.h"
23+
#include "internal/unicode_transcoder.h"
2424

2525
#include <stdexcept>
2626

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
2121
// SOFTWARE.
2222

23-
#include "internal/unicode.h"
23+
#include "internal/unicode_transcoder.h"
2424

2525
#include <gtest/gtest.h>
2626

0 commit comments

Comments
 (0)