Repository navigation
Fix pyproject.toml and improve Modbus TCP proxy example - #105
Merged
Merged
Conversation
the duplicate script name caused `pip install .` to fail
- `asyncio.StreamReader.readexactly` throws when not enough data can be read. - use proper logging.
gratux
changed the title
Owner
|
Merged. Thanks for your contribution @gratux! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing the Modbus TCP proxy utility, I noticed the usage of
asyncio.StreamReader.readexactlyis not quite correct: the documentation states an exception is raised in case not enough data can be read.With the old behavior, closing the TCP connection would not properly disconnect the Solarman session.
This PR changes the incorrect error handling to catch the exception and disconnect the session.
Also, the utility now uses a proper logger instead of raw print statements.
Additional fixes: