parse %-words as inputs when splitting edited label fragments - #3565
Open
gigamonkey wants to merge 1 commit into
Open
parse %-words as inputs when splitting edited label fragments#3565gigamonkey wants to merge 1 commit into
gigamonkey wants to merge 1 commit into
Conversation
Typing 'bar %m' into the title-text field of the input-slot dialog (the '+' in the block editor) created an input named '%m' instead of 'm': refreshPrototype split the multi-word label into plain text fragments, but the rebuilt prototype spec turned the '%m' word into an input morph, which then got the stale text fragment (labelString '%m', type null) assigned to it. Mirror labelPart's parsing when splitting: a word starting with '%' becomes an input fragment with the '%' stripped. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that typing
bar %minto the title-text field of the input-slot dialog (the+in the block editor) leaves us in a weird state: It turns%minto an input but it's named%minstead ofm:refreshPrototypesplit the multi-word label into plain text fragments, but the rebuilt prototype spec turned the%mword into an input morph, which then got the stale text fragment (labelString '%m', type null) assigned to it.This PR mirror's
labelPart's parsing when splitting: a word starting with%becomes an input fragment with the%stripped.