Skip to content

Commit 4e70cc3

Browse files
jnrahmeclaude
andcommitted
Document linting, formatting, and image-caching conventions
Reflect the ESLint/Prettier quality gates, expo-image usage, and dynamic-type capping in the contributor and agent guides. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
1 parent 2ca805d commit 4e70cc3

2 files changed

Lines changed: 12 additions & 2 deletions

File tree

CONTRIBUTING.md

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,15 @@ npm run web
2424
Before opening a pull request or pushing a material change, run:
2525

2626
```bash
27+
npm run format
2728
make verify
2829
make expo-check
2930
```
3031

31-
`make verify` runs strict TypeScript and Jest. `make expo-check` verifies that
32-
installed package versions match Expo SDK 56 expectations.
32+
`make verify` runs strict TypeScript, ESLint, and the Jest suite with coverage
33+
gates. `npm run format` applies Prettier (CI enforces formatting via
34+
`npm run format:check`). `make expo-check` verifies that installed package
35+
versions match Expo SDK 56 expectations.
3336

3437
## Engineering Principles
3538

@@ -39,6 +42,10 @@ installed package versions match Expo SDK 56 expectations.
3942
- Prefer accessible React Native primitives with clear labels and 44pt+ touch
4043
targets.
4144
- Use the existing theme tokens rather than hardcoded per-screen colors.
45+
- Load remote images through `CachedImageBackground` (expo-image) so artwork is
46+
cached and shows a placeholder instead of a blank frame.
47+
- Cap font scaling on large display text with `typography.displayMaxScale`, and
48+
leave body text free to scale for accessibility.
4249
- Add tests when behavior changes or a contract becomes easier to regress.
4350

4451
## Pull Request Checklist

docs/REPO_PROFILE.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ https://jnrahme.github.io/GameTimeTest/
3030
- zod
3131
- react-navigation
3232
- tanstack-query
33+
- expo-image
34+
- eslint
35+
- prettier
3336

3437
## Public Surface Checklist
3538

0 commit comments

Comments
 (0)