Add pluggable HTTP transports - #841
Draft
jnunemaker wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTTParty::Transportcontract with normalized request, response, and streaming chunk objectsHTTParty::Transport::NetHttpbackendHTTParty::Transport::Curlbackend powered bycurb, selectable withtransport :curlWhy
HTTParty's request pipeline was coupled directly to Net::HTTP response and connection behavior. That made an optional libcurl backend difficult without requiring it to impersonate Net::HTTP.
This introduces a whole-request transport boundary while keeping redirects, cookies, authentication, parsing, logging, decompression, and response policy in HTTParty. Net::HTTP remains the default and continues to honor the existing
connection_adaptercontract.User impact
Existing clients continue to use Net::HTTP without configuration changes.
Curl is opt-in and does not add a runtime dependency:
Third-party transports can register a short name with
HTTParty::Transport.register. Class-owned transport instances are reusable and close throughClient.close; request-level overrides are closed after the request.The Curl backend rejects unsupported Net::HTTP-specific options instead of silently degrading behavior. Its timeout and request-upload buffering differences are documented.
Validation
mise x ruby@3.1.1 -- ruby -Ilib -S rakegit diff --check