fix(ci): harden the Docker release path - #9529
Open
shauneccles wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Docker publish workflow interpolates the manual
versioninput directly into Bash source before parsing. It also restores and writes a shared GitHub Actions build cache in the release job that publishes to GHCR.That gives a workflow input a shell parsing boundary and lets cache state produced outside the release run influence the published image build.
Change
GITHUB_ENVwith quotedprintfargumentstype=ghacache restore and save from the image-publishing stepThe image tags, platforms and registry permissions are unchanged. The trade-off is a slower release build with no cross-run cache trust.
Verification
template-injectionfindings are removedgit diff --checkpassedAction pinning and checkout credential persistence are deliberately left for the follow-up repository-wide pinning PR.