Skip to content

Commit 0899ff0

Browse files
committed
fix: replace deprecated Trending icons with AutoMirrored versions
- Update TrendingUp, TrendingDown, and TrendingFlat icons to use Icons.AutoMirrored.Filled - Resolves deprecation warnings in EnhancedShotTrendsCard and SimplifiedMetricCard
1 parent a821acd commit 0899ff0

3 files changed

Lines changed: 14 additions & 11 deletions

File tree

app/src/main/java/com/jodli/coffeeshottimer/ui/components/ShotRecordedDialog.kt

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ import com.jodli.coffeeshottimer.domain.model.TasteSecondary
2020
import com.jodli.coffeeshottimer.domain.usecase.ShotRecommendation
2121
import com.jodli.coffeeshottimer.ui.theme.LocalSpacing
2222

23+
private const val EXTRACTION_TIME_FAST_THRESHOLD = -3
24+
private const val EXTRACTION_TIME_SLOW_THRESHOLD = 3
25+
2326
/**
2427
* Dialog shown after successfully recording a shot, with optional recommendations.
2528
*/
@@ -133,9 +136,9 @@ fun ShotRecordedDialog(
133136
if (grindAdjustment != null) {
134137
// Determine the explanation text first
135138
val explanationText = when {
136-
grindAdjustment.extractionTimeDeviation < -3 ->
139+
grindAdjustment.extractionTimeDeviation < EXTRACTION_TIME_FAST_THRESHOLD ->
137140
stringResource(R.string.feedback_shot_ran_fast)
138-
grindAdjustment.extractionTimeDeviation > 3 ->
141+
grindAdjustment.extractionTimeDeviation > EXTRACTION_TIME_SLOW_THRESHOLD ->
139142
stringResource(R.string.feedback_shot_ran_slow)
140143
grindAdjustment.tasteIssue == TastePrimary.SOUR ->
141144
stringResource(R.string.feedback_sour_taste)

app/src/main/java/com/jodli/coffeeshottimer/ui/components/analytics/EnhancedShotTrendsCard.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ import androidx.compose.foundation.layout.fillMaxWidth
88
import androidx.compose.foundation.layout.height
99
import androidx.compose.foundation.layout.size
1010
import androidx.compose.material.icons.Icons
11-
import androidx.compose.material.icons.filled.TrendingDown
12-
import androidx.compose.material.icons.filled.TrendingFlat
13-
import androidx.compose.material.icons.filled.TrendingUp
11+
import androidx.compose.material.icons.automirrored.filled.TrendingDown
12+
import androidx.compose.material.icons.automirrored.filled.TrendingFlat
13+
import androidx.compose.material.icons.automirrored.filled.TrendingUp
1414
import androidx.compose.material3.Icon
1515
import androidx.compose.material3.MaterialTheme
1616
import androidx.compose.material3.Text
@@ -175,20 +175,20 @@ private fun getTrendIndicator(trends: ShotTrends): Triple<ImageVector, String, a
175175
return if (trends.isImproving) {
176176
val changePoints = abs(ratioChange + timeChange).toInt()
177177
Triple(
178-
Icons.Default.TrendingUp,
178+
Icons.AutoMirrored.Filled.TrendingUp,
179179
stringResource(R.string.analytics_trend_improving_format, changePoints),
180180
androidx.compose.ui.graphics.Color(COLOR_GREEN)
181181
)
182182
} else if (abs(ratioChange) < RATIO_STABLE_THRESHOLD && abs(timeChange) < TIME_STABLE_THRESHOLD) {
183183
Triple(
184-
Icons.Default.TrendingFlat,
184+
Icons.AutoMirrored.Filled.TrendingFlat,
185185
stringResource(R.string.analytics_trend_stable_text),
186186
androidx.compose.ui.graphics.Color(COLOR_ORANGE)
187187
)
188188
} else {
189189
val changePoints = abs(ratioChange + timeChange).toInt()
190190
Triple(
191-
Icons.Default.TrendingDown,
191+
Icons.AutoMirrored.Filled.TrendingDown,
192192
stringResource(R.string.analytics_trend_declining_format, changePoints),
193193
androidx.compose.ui.graphics.Color(COLOR_RED)
194194
)

app/src/main/java/com/jodli/coffeeshottimer/ui/components/analytics/SimplifiedMetricCard.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import androidx.compose.foundation.layout.Column
66
import androidx.compose.foundation.layout.Row
77
import androidx.compose.foundation.layout.size
88
import androidx.compose.material.icons.Icons
9-
import androidx.compose.material.icons.filled.TrendingUp
9+
import androidx.compose.material.icons.automirrored.filled.TrendingUp
1010
import androidx.compose.material3.Icon
1111
import androidx.compose.material3.MaterialTheme
1212
import androidx.compose.material3.Text
@@ -94,13 +94,13 @@ private fun SimplifiedMetricCardPreview() {
9494
verticalArrangement = Arrangement.spacedBy(16.dp),
9595
) {
9696
SimplifiedMetricCard(
97-
icon = Icons.Default.TrendingUp,
97+
icon = Icons.AutoMirrored.Filled.TrendingUp,
9898
primaryText = "92",
9999
secondaryText = "Quality Score"
100100
)
101101

102102
SimplifiedMetricCard(
103-
icon = Icons.Default.TrendingUp,
103+
icon = Icons.AutoMirrored.Filled.TrendingUp,
104104
primaryText = "85%",
105105
secondaryText = "In Optimal Zone",
106106
onClick = { }

0 commit comments

Comments
 (0)