Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Memory Leak on multiple times opening @picmo/popup-picker #279

Description

@kapilkumawat86

You can see if we open every time this picker, we are getting new reference but still we have old reference in memory
image

You see heap snapshot here https://goldcastio-my.sharepoint.com/:u:/g/personal/kapil_goldcast_io/Ed1c7omX8aNCppu2pxr8F60ByBk1ax_9UWIBuh3c2CbI3Q?e=tGURVU

In my opinion, at this line of code we are removing the references but the child class still have reference so can we put null also after remove.
https://github.com/joeattardi/picmo/blob/3525583e049cdea34e2ce48b9516983b9f02e209/packages/picmo/src/views/view.ts#LL209C5-L209C21

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions