feat: confirm before stopping a live broadcast - #27
Merged
Conversation
The toolbar stop button tore the broadcast down on the first tap, so a stray touch could drop the stream mid-session. When live, tapping stop now asks for confirmation with a destructive "Stop Broadcast" action and a "Keep Streaming" cancel; starting a broadcast is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a confirmation step before ending a live broadcast, so a stray tap on the toolbar stop button can't drop the stream mid-session.
confirmationDialoginstead of tearing the broadcast down immediately.capture.stop()) and a "Keep Streaming" cancel, with the message "You're live. Stopping ends the stream for everyone watching."Testing
xcodegen generate+xcodebuild buildfor theStreamscheme on the iOS 27 simulator SDK: BUILD SUCCEEDED.StreamCoreonly (GitHub runners lack the iOS 27 SDK); the dialog behavior is verified on a physical iOS 27 device.🤖 Generated with Claude Code