fix: cap the Video settings summary to the device ceiling (follow-up to #17) - #29
Merged
Conversation
#17) The 1080p60 unlock (#28) gated the Quality and Frame Rate pickers by StreamCapability but left the collapsed Video launcher summary interpolating the raw persisted videoQuality/frameRate. On a device whose ceiling is below a stored value — e.g. a settings blob restored via iCloud/backup from a more capable phone — the row rendered "1080p · … · 60 fps" while the pickers and the actual encoded stream were correctly capped, reintroducing the exact over-promise #17 set out to remove. Show the effective (min'd) values so the summary matches what streams. Also pins two StreamCore contracts an adversarial review flagged as untested: the StreamCapability core-count boundary at exactly 6 (5 cores + ample RAM -> 30 fps) and the zero-dimension encodeSize fallback at a 1080 ceiling and under clamping. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up polish to the 1080p60 unlock (#17 / #28).
The unlock gated the Quality and Frame Rate pickers by
StreamCapability, but the collapsed Video launcher summary still interpolated the raw persistedvideoQuality/frameRate. On a device whose ceiling is below a stored value — e.g. a settings blob restored via iCloud/backup from a more capable phone — the row rendered "1080p · … · 60 fps" while the pickers and the actual encoded stream were correctly capped, reintroducing the exact over-promise #17 set out to remove. Now the summary shows the effective (min'd) values so it matches what streams.Also pins two
StreamCorecontracts an adversarial multi-agent review flagged as untested:StreamCapabilitycore-count boundary at exactly 6 (5 cores + ample RAM → 30 fps)encodeSizefallback at a 1080 ceiling and under clampingVerification: 60 StreamCore tests pass; full app target builds against the iOS 27 SDK.
🤖 Generated with Claude Code