Skip to content

Commit 9f13ceb

Browse files
committed
ci(release): fail the sub-package publish step on any single failure, fix llvm-mingw asset URL
Two first-tag blockers found in review: - The platform publish loop had no failure propagation: with seven sequential npm publishes and no set -e, a mid-loop failure (OIDC not yet configured on one package, registry hiccup) would still let the step pass and the main package would ship with missing optionalDependencies. Now set -euo pipefail; a failed run can simply be re-run (npm rejects already-published versions but later packages still go out). - The win32-arm64 llvm-mingw pin referenced ...-ucrt-ubuntu-20.04-x86_64.tar.xz, which does not exist in the 20250417 release (404) — the release only ships an ubuntu-22.04 variant. Updated URL and extraction dir.
1 parent 998c420 commit 9f13ceb

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

‎.github/workflows/release.yml‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,8 +101,8 @@ jobs:
101101
- name: Install llvm-mingw
102102
if: matrix.llvm_mingw
103103
run: |
104-
curl -sSL https://github.com/mstorsjo/llvm-mingw/releases/download/20250417/llvm-mingw-20250417-ucrt-ubuntu-20.04-x86_64.tar.xz | sudo tar -xJ -C /opt
105-
echo "/opt/llvm-mingw-20250417-ucrt-ubuntu-20.04-x86_64/bin" >> "$GITHUB_PATH"
104+
curl -sSL https://github.com/mstorsjo/llvm-mingw/releases/download/20250417/llvm-mingw-20250417-ucrt-ubuntu-22.04-x86_64.tar.xz | sudo tar -xJ -C /opt
105+
echo "/opt/llvm-mingw-20250417-ucrt-ubuntu-22.04-x86_64/bin" >> "$GITHUB_PATH"
106106
107107
- name: Build bridge (stripped)
108108
run: node tools/build-bridge.js
@@ -163,6 +163,7 @@ jobs:
163163

164164
- name: Publish platform sub-packages
165165
run: |
166+
set -euo pipefail
166167
for d in subpkgs/*; do
167168
echo "== publishing $(basename "$d") =="
168169
(cd "$d" && npm publish --provenance)

0 commit comments

Comments
 (0)