Skip to content

Remove the lasym output doubling that compensated the old fixaray norm - #11

Open
CharlesCNorton wants to merge 1 commit into
jonathanschilling:masterfrom
CharlesCNorton:fix/lasym-output-normalization
Open

Remove the lasym output doubling that compensated the old fixaray norm#11
CharlesCNorton wants to merge 1 commit into
jonathanschilling:masterfrom
CharlesCNorton:fix/lasym-output-normalization

Conversation

@CharlesCNorton

Copy link
Copy Markdown
Contributor

Fixes #4.

wrout.f90 and jxbforce.f90 doubled the forward-transform normalization for lasym = T to compensate the halved dnorm that fixaray used to set for that case (SPH012314). That branch of dnorm was removed in bd2d0f3 and 05c81f6, so the two doublings are the only remaining trace of it and every lasym output built through them came out at twice its value, or four times where jxbforce and wrout both applied it. The matching removal was made in PARVMEC in 82f401b.

The comment at the symforce call in funct3d.f90 described the halved norm as well and is dropped together with the two commented-out gc = 2*gc blocks it referred to.

Checked with input.cth_like_fixed_bdy run with LASYM = F and LASYM = T: after the change every wout variable agrees between the two runs to 1e-10 relative, and all asymmetric arrays are zero to machine precision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Output normalization is doubled for lasym in wrout and jxbforce

1 participant