Remove the lasym output doubling that compensated the old fixaray norm - #11
Open
CharlesCNorton wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4.
wrout.f90andjxbforce.f90doubled the forward-transform normalization forlasym = Tto compensate the halveddnormthatfixarayused to set for that case (SPH012314). That branch ofdnormwas removed in bd2d0f3 and 05c81f6, so the two doublings are the only remaining trace of it and every lasym output built through them came out at twice its value, or four times where jxbforce and wrout both applied it. The matching removal was made in PARVMEC in 82f401b.The comment at the symforce call in
funct3d.f90described the halved norm as well and is dropped together with the two commented-outgc = 2*gcblocks it referred to.Checked with
input.cth_like_fixed_bdyrun withLASYM = FandLASYM = T: after the change every wout variable agrees between the two runs to 1e-10 relative, and all asymmetric arrays are zero to machine precision.