Scan the complete cross-section for the geometry table of a lasym run - #20
Open
CharlesCNorton wants to merge 1 commit into
Open
Scan the complete cross-section for the geometry table of a lasym run#20CharlesCNorton wants to merge 1 commit into
CharlesCNorton wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18.
The cross-section table scans
thetain[0, pi]at the planevand takes the other half of the contour from the reflected plane withZ -> -Z, which is the stellarator-symmetric reconstruction. Forlasym = Tthe stored surface already holds the complete contour, so it is now scanned in a single pass overntheta3points at the plane itself; the symmetric run keeps its two passes overntheta2.Checked with
input.cth_like_fixed_bdyrun withLASYM = FandLASYM = T: the ellipticity, indentation, d-shape and shift columns agree between the two runs and with the build before the change. Oninput.cth_like_fixed_bdy_asym(VMEC++ test data) the boundary ellipticity changes from 2.03788 to 2.06080 in the v = 0 plane and from 0.71460 to 0.73748 in the v = pi/Nfp plane, since the lower half of the contour is now the stored one instead of a copy of the upper half. The wout file is unchanged bit for bit.