Initialize the coarse retry after a bad initial Jacobian - #29
Open
philippbogdan wants to merge 1 commit into
Open
Initialize the coarse retry after a bad initial Jacobian#29philippbogdan wants to merge 1 commit into
philippbogdan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An initial bad Jacobian leaves
ns_oldat the failed grid. The fallback selectsnsval=3, but thens_old <= nsvalguard then skips initialization. Reset the radial state and restore the original input axis before the coarse attempt, and limit this recovery to the first requested grid when it has more than three surfaces.The new regression uses the fixed boundary of QUASR configuration 14802. The unmodified solver stops at
ns=8withier_flag=1; the repaired solver follows8 -> 3 -> 8 -> 16 -> 31and reaches all three requested force tolerances of1e-9. The test checks the actual residuals and final resolution as well as the single coarse stage.Validation:
Built with GNU Fortran 16.2.0 and NetCDF-Fortran 4.6.4 on macOS arm64. The fixture records its QUASR provenance.