Size the T_l recurrence passes of the analytic add-back by their growth rate - #33
Open
CharlesCNorton wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two homogeneous solutions of Eq (A15) form a pair of modulus sqrt(adm/adp) for T+, and its reciprocal for T-, so stepping the recurrence upward over mf + nf steps multiplies the rounding of its inputs by that factor.
analytsteps upward for every point regardless of that growth.This tabulates T+ and T- before the l-sum, upward where the growth is small and downward from a seed above mf + nf where it is not, following the same criterion as ORNL-Fusion/PARVMEC#84 and proximafusion/vmecpp#836.
all_tlpandall_tlmalready hold the sequences, so the l-sum reads them instead of rollingtlp/tlp1/tlp2.Accuracy is measured against the same recurrence carried at 60 digits, seeded with the closed form for T(0), using the metric this code dumps for the surface it is actually on (
dump_vac1n_surfaceanddump_vac1n_analytat one iteration offb/input.cth_like_free_bdy). Worst relative error in T+ over the surface:The gain grows with the growth factor, which on a boundary with a larger adm/adp spread is far bigger: on the exact dipole test in PARVMEC at mpol 16, ntor 16 the vacuum residual went from 6.5e-1 to 2.3e-4.
Where the upward pass is kept the tabulation is unchanged, and on
fb/input.cth_like_free_bdyat its own resolution the convergedrmncagrees with master to 5.8e-14.ctestpasses.