fix: pass train_dataset and eval_dataset to CloneDetectionTrainer constructor - #3
Merged
jorge-martinez-gil merged 1 commit intoMay 28, 2026
Conversation
…structor The Trainer.__init__ validates that eval_dataset is provided when eval_strategy='epoch' is set. Datasets were previously only assigned in run(), causing the ValueError before training could start. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HuggingFace's
Trainer.__init__validates thateval_datasetis provided whenevereval_strategyis not"no". Becauseget_training_argsdefaultseval_strategyto"epoch", constructingCloneDetectionTrainerwithout datasets caused an immediateValueErrorbefore any training could begin.The fix passes
train_datasetandeval_datasetdirectly to the constructor inrun_clone_experiment.py. Therun()method already assigns them internally, but the constructor validation fires first and requires them upfront.