Fix more panics following PR #51 - #52
Open
toomim wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From #51:
Here are fixes to some more that were lurking. Strengthened the test too. It now
tests byte replacement, deletion and truncation as well as insertion, over three
shapes of document instead of one.
One of the fixes is to the #51 fix itself. The
n == 0guard on local parentsrejects a zero offset, but
next_time - nstill underflows when n is largerthan next_time.
The wasm part is separated into its own commit because it changes a visible JS API:
fromBytesused to unwrap, creating an illegible fault. Now it throws.