Skip to content

Commit 18b94d3

Browse files
gba release: drop _payload.c attachments
The two _payload.c files are C-array embeddings of the corresponding _mb.gba ROMs, used for compile-time linking into a host firmware. Submodule consumers (joypad-os) read those from the committed gba/build/ tree, not from a downloaded Release asset. Attaching them to the Release was just noise that gave end-users two extra "what is this?" downloads next to the playable ROMs. After this change the Release attaches only the two playable ROMs (joypad_mb.gba, tester_mb.gba). CI build-verification artifacts in verify-build.yml still include the .c files -- those uploads are for inspecting build output from the Actions tab, not end-user assets.
1 parent 42cd201 commit 18b94d3

2 files changed

Lines changed: 12 additions & 6 deletions

File tree

.github/workflows/release.yml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -127,10 +127,13 @@ jobs:
127127
working-directory: gba
128128
run: |
129129
mkdir -p _release
130-
cp build/joypad/joypad_mb.gba _release/
131-
cp build/joypad/joypad_payload.c _release/
132-
cp build/tester/tester_mb.gba _release/
133-
cp build/tester/tester_payload.c _release/
130+
# Only the playable .gba ROMs go in the public release.
131+
# _payload.c (C-array form for compile-time embedding) lives in
132+
# the committed gba/build/ tree; submodule consumers like
133+
# joypad-os pull it from the working tree, not from a Release
134+
# artifact, so attaching it to the Release would be noise.
135+
cp build/joypad/joypad_mb.gba _release/
136+
cp build/tester/tester_mb.gba _release/
134137
ls -la _release/
135138
136139
- name: Stage release artifacts (PC Engine)

gba/README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,11 @@ unconditional handshake-complete write).
144144

145145
Tagged as `gba-v<semver>` from the repo root — see
146146
[`gba/CHANGELOG.md`](CHANGELOG.md) for per-version notes. The release
147-
workflow attaches `joypad_mb.gba`, `joypad_payload.c`, `tester_mb.gba`,
148-
and `tester_payload.c` to each GitHub Release automatically.
147+
workflow attaches the two playable ROMs (`joypad_mb.gba`,
148+
`tester_mb.gba`) to each GitHub Release. The C-array embed forms
149+
(`build/<variant>/<variant>_payload.c`) stay in the committed `build/`
150+
tree for submodule consumers — they're not duplicated to Release
151+
artifacts.
149152

150153
## Origin / credits
151154

0 commit comments

Comments
 (0)