Skip to content

Commit 8f327ad

Browse files
gba release: ship only tester_mb.gba, not the eyes payload
The eyes variant (joypad_mb.gba) is a firmware payload meant to be multibooted by a host (joypad-os keeps its own independent copy for that). It has no useful standalone runtime, so attaching it to a public Release confused the "download and play" mental model. After this change the gba Release attaches only tester_mb.gba -- the standalone joypad button tester. The eyes build still happens in CI (verify-build.yml uploads both variants for source-tree inspection) and the eyes source stays in the repo, but it's no longer treated as a publicly distributed ROM.
1 parent 18b94d3 commit 8f327ad

2 files changed

Lines changed: 12 additions & 11 deletions

File tree

.github/workflows/release.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -127,12 +127,13 @@ jobs:
127127
working-directory: gba
128128
run: |
129129
mkdir -p _release
130-
# Only the playable .gba ROMs go in the public release.
131-
# _payload.c (C-array form for compile-time embedding) lives in
132-
# the committed gba/build/ tree; submodule consumers like
133-
# joypad-os pull it from the working tree, not from a Release
134-
# artifact, so attaching it to the Release would be noise.
135-
cp build/joypad/joypad_mb.gba _release/
130+
# Public release ships only the user-facing tester ROM.
131+
# The eyes variant (joypad_mb.gba) is a firmware payload meant
132+
# to be multibooted by a separate host (joypad-os keeps its
133+
# own copy for that role), not run standalone -- end-users
134+
# downloading the release want a playable joypad tester. The
135+
# eyes build still lives in gba/build/ for source-tree consumers
136+
# but doesn't get a Release attachment.
136137
cp build/tester/tester_mb.gba _release/
137138
ls -la _release/
138139

gba/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -144,11 +144,11 @@ unconditional handshake-complete write).
144144

145145
Tagged as `gba-v<semver>` from the repo root — see
146146
[`gba/CHANGELOG.md`](CHANGELOG.md) for per-version notes. The release
147-
workflow attaches the two playable ROMs (`joypad_mb.gba`,
148-
`tester_mb.gba`) to each GitHub Release. The C-array embed forms
149-
(`build/<variant>/<variant>_payload.c`) stay in the committed `build/`
150-
tree for submodule consumers — they're not duplicated to Release
151-
artifacts.
147+
workflow attaches only `tester_mb.gba` — the user-facing standalone
148+
button tester. The eyes variant (`joypad_mb.gba`) is a firmware payload
149+
meant to be multibooted by a host firmware (joypad-os keeps its own
150+
copy for that role); it builds and ships in `gba/build/joypad/` for
151+
source-tree inspection but doesn't get a Release attachment.
152152

153153
## Origin / credits
154154

0 commit comments

Comments
 (0)