test(routines): exercise pinned G36 TrimAndRespond pipeline - #100
Conversation
jscott3201
left a comment
There was a problem hiding this comment.
Cycle 1 consolidated review: both independent reviewers identified the same confirmed CI blocker, G36-CI-ROOT-001. The exact reviewed head remains 80055a63b1e71f1304f1a3b4632b1262a3f679fd; its build check passed and verify failed in the new integration step. No distinct blocker/major findings or deferred minor/nit changes remain.
| OCL_G36_RELEASE_ROOT: ../modelica-buildings-release | ||
| OCL_G36_DEVELOPMENT_ROOT: ../modelica-buildings-development |
There was a problem hiding this comment.
[G36-CI-ROOT-001] Major — external checkout paths resolve from the Cargo package root. The exact-head verify job failed here with OCL_G36_RELEASE_ROOT must name an openable directory: No such file or directory. Cargo starts this integration test from cxf-library/tools/routine-compiler, so ../modelica-buildings-* resolves under cxf-library/tools, not to the workflow-level sibling checkouts. Use ../../../modelica-buildings-release and ../../../modelica-buildings-development, then require the explicit integration step to pass. This is introduced by the PR and currently blocks every verify run.
jscott3201
left a comment
There was a problem hiding this comment.
Cycle 2 final review: PASS at immutable head f1642e7609b5d76a1c40fb852376b7690bb180f9.
- Prior finding
G36-CI-ROOT-001: resolved by the bounded two-path repair. - Both independent reviewers are blocker/major-clean.
- Exact-head
buildandverifychecks are successful. - No minor/nit changes are deferred from this cycle.
Summary
Buildings.Controls.OBC.ASHRAE.G36.Generic.TrimAndRespondsourcesamplePeriodandnumOfReqthroughcompile_validated_from_rootsand assert deterministic bound rows and exact source claimsThe generic syntax stage proves direct class and public-member identity. It does not claim declared-type, connector-direction, inheritance, dependency, Modelica compilation, or behavior validation; the existing declaration verifier continues to check the exact declared member types.
Validation
python3 tools/lint/g36_source.py --check --release-root "$OCL_G36_RELEASE_ROOT" --development-root "$OCL_G36_DEVELOPMENT_ROOT"cargo test --locked --manifest-path tools/routine-compiler/Cargo.toml --test g36_trim_and_respond -- --include-ignoredcargo test --locked --manifest-path tools/routine-compiler/Cargo.tomlcargo clippy --locked --manifest-path tools/routine-compiler/Cargo.toml --all-targets -- -D warningscargo fmt --manifest-path tools/routine-compiler/Cargo.toml -- --checkactionlint .github/workflows/verify.yml