Skip to content

test(routines): exercise pinned G36 TrimAndRespond pipeline - #100

Merged
jscott3201 merged 2 commits into
mainfrom
test/rust-g36-trim-and-respond
Aug 25, 2026
Merged

test(routines): exercise pinned G36 TrimAndRespond pipeline#100
jscott3201 merged 2 commits into
mainfrom
test/rust-g36-trim-and-respond

Conversation

@jscott3201

@jscott3201 jscott3201 commented Aug 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • add an external-root integration test for the pinned Buildings.Controls.OBC.ASHRAE.G36.Generic.TrimAndRespond source
  • pass samplePeriod and numOfReq through compile_validated_from_roots and assert deterministic bound rows and exact source claims
  • run the ignored-by-default target explicitly in CI after full pinned-source inventory validation

The generic syntax stage proves direct class and public-member identity. It does not claim declared-type, connector-direction, inheritance, dependency, Modelica compilation, or behavior validation; the existing declaration verifier continues to check the exact declared member types.

Validation

  • python3 tools/lint/g36_source.py --check --release-root "$OCL_G36_RELEASE_ROOT" --development-root "$OCL_G36_DEVELOPMENT_ROOT"
  • cargo test --locked --manifest-path tools/routine-compiler/Cargo.toml --test g36_trim_and_respond -- --include-ignored
  • cargo test --locked --manifest-path tools/routine-compiler/Cargo.toml
  • cargo clippy --locked --manifest-path tools/routine-compiler/Cargo.toml --all-targets -- -D warnings
  • cargo fmt --manifest-path tools/routine-compiler/Cargo.toml -- --check
  • actionlint .github/workflows/verify.yml

@jscott3201 jscott3201 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cycle 1 consolidated review: both independent reviewers identified the same confirmed CI blocker, G36-CI-ROOT-001. The exact reviewed head remains 80055a63b1e71f1304f1a3b4632b1262a3f679fd; its build check passed and verify failed in the new integration step. No distinct blocker/major findings or deferred minor/nit changes remain.

Comment thread .github/workflows/verify.yml Outdated
Comment on lines +93 to +94
OCL_G36_RELEASE_ROOT: ../modelica-buildings-release
OCL_G36_DEVELOPMENT_ROOT: ../modelica-buildings-development

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[G36-CI-ROOT-001] Major — external checkout paths resolve from the Cargo package root. The exact-head verify job failed here with OCL_G36_RELEASE_ROOT must name an openable directory: No such file or directory. Cargo starts this integration test from cxf-library/tools/routine-compiler, so ../modelica-buildings-* resolves under cxf-library/tools, not to the workflow-level sibling checkouts. Use ../../../modelica-buildings-release and ../../../modelica-buildings-development, then require the explicit integration step to pass. This is introduced by the PR and currently blocks every verify run.

@jscott3201 jscott3201 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cycle 2 final review: PASS at immutable head f1642e7609b5d76a1c40fb852376b7690bb180f9.

  • Prior finding G36-CI-ROOT-001: resolved by the bounded two-path repair.
  • Both independent reviewers are blocker/major-clean.
  • Exact-head build and verify checks are successful.
  • No minor/nit changes are deferred from this cycle.

@jscott3201
jscott3201 merged commit f8f82ce into main Aug 25, 2026
3 checks passed
@jscott3201
jscott3201 deleted the test/rust-g36-trim-and-respond branch August 25, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant