Renumber all fault rules into the general {EQUIP}-{NNNN} namespace + fault-code registry - #40
Merged
Merged
Conversation
…registry Per Justin's direction: one general namespace, contiguous per family from 0001 in authoring order, no provenance bands (the band breakout from #38 is removed from SCHEMA, the sidebar, and lint). 92 rules renamed — the CXF never embeds the fault ID, so every content_id is unchanged and the full suite re-verifies green (1023 scenario passes). faults/registry.json is the library-wide fault-code map: id, family, name, method, status, legacy_id (the old {EQUIP}-FC-{NNN} code). tools/lint/registry.py replaces id_bands.py in CI: dir/registry bijection, format, per-family contiguity, card-field sync, legacy uniqueness. The book gains a Fault Code Map page rendered from it. Cross-reference sweep by tools/authoring/renumber.py (one-shot, composite shorthand expanded) plus manual fixes: reserved rules take new-namespace IDs (VAV-0010 drift, RTU-0007 condenser airflow), composite mentions PR #38 missed, hypothetical sibling-rule prose, and the reference's own IDs (META-FC-050, CHW-FC-008/009) kept as external citations. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Per direction: one general namespace —
{EQUIP}-{NNNN}, contiguous from 0001 per family in authoring order, no provenance bands (the #38 band breakout is removed from SCHEMA, sidebar, and lint). All 92 rules renamed; everycontent_idunchanged (the CXF never embeds the fault ID) and the full suite re-verifies green — 1023 scenario passes.The map
faults/registry.json(cxf-library/registry/v1): one row per rule — id, family, name, method, status, legacy_id (the old{EQUIP}-FC-{NNN}code).tools/lint/registry.pyenforces in CI: dir↔registry bijection, ID format, per-family contiguity from 0001, card-field sync, legacy uniqueness. The book gains a Fault Code Map page rendered from it.Sweep details
tools/authoring/renumber.py(one-shot, committed for the record) rewrote every tracked reference including composite shorthand (SYS-FC-054/055/100/101). Manual passes: reserved rules took new-namespace IDs (VAV-0010 drift, RTU-0007 condenser airflow restriction); composite mentions PR #38's sed missed; hypothetical sibling-rule prose de-ID'd; the reference's own identifiers (META-FC-050, CHW-FC-008/009) kept as external citations; SYS-0005's ID-decision Deviation rewritten historically.Verification
registry + svg lints clean, cargo verify --all green at the pin, book builds (92 pages + registry page), renamed flat sidebar confirmed in-browser.
🤖 Generated with Claude Code