feat(routines): add Title 24 zero-offset high limit - #61
Merged
Conversation
jscott3201
commented
Aug 22, 2026
jscott3201
left a comment
Owner
Author
There was a problem hiding this comment.
Cycle 1 consolidated review: PASS
Target: 425298c8bbb5a8ecf180335be8e1cdf3db10385a...e7964a6152c8cd45c96f5c1cd5d79bc5ecbb5541
review-luna: no blocker or major findingsreview-dataflow-inkling: no blocker or major findings- Deferred findings: none
- Exact-head checks:
book / buildandverify / verifysucceeded
The PR head remained unchanged after both independent reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AirEconomizerHighLimitsspecialization and update catalog count claimsScope
The upstream source selects a direct
TRetbranch for this bucket. The donor fixture represents that path with an explicitAddParameter(p=0)identity block. This change does not modify the engine, donor or source pins, schema, coverage data, validators, or tests.Revisions
425298c8bbb5a8ecf180335be8e1cdf3db10385ae7964a6152c8cd45c96f5c1cd5d79bc5ecbb5541e2ff2f84577d9be65a49e6cb5440c223f612681741e997fd130c5e454446b40bcc3ba576429876b4a131864e4c4df22ebcd52bb8da439de0087ac365Validation
python3 -m unittest discover -s tools/lint/tests -v: 29 passedpython3 tools/lint/svg_fitment.py: 141 SVGs cleanpython3 tools/lint/registry.py: 137 rules OKpython3 tools/lint/routines.py: 3 routines OKpython3 tools/lint/routines.py --donor-root DONOR_PIN-checkout: 3 routines, donor parity checkedcargo test --manifest-path tools/verify/Cargo.toml: 5 passedcargo run --manifest-path tools/verify/Cargo.toml -- --routines: all three routines replayedcargo run --manifest-path tools/verify/Cargo.toml -- --all: 137 fault directories passedpython3 -m unittest discover -s tools/dataset_harness/tests -v: 32 passedpython3 tools/book/generate.py: passed twice with no tracked deltamdbook build book: passedgit diff --check: passedEvidence and exclusions
The routine remains
source_evidencedat E3. Canonical-class, family, donor-set, and guideline completeness remain partial or unclaimed. Other Title 24 offsets, fixed dry-bulb variants, Boolean or Integer interfaces, stateful routines, and E4/E5 evidence remain out of scope.