Normalize audited point semantic mappings - #74
Merged
Conversation
jscott3201
commented
Aug 23, 2026
jscott3201
left a comment
Owner
Author
There was a problem hiding this comment.
Cycle 1 review target: e1a6f66d2228635119e5d5cdf67387ba197b395e.
PASS — both independent reviewers are blocker/major-clean. The audited mappings, pin-derived namespace checks, deterministic JSON failure behavior, direction rules, bounded mapping guard, CI wiring, and downstream point-key flows were reviewed at this exact head.
Exact-head build and verify checks completed successfully. All 14 dictionary paths and 183 canonical point names remain unchanged. No minor or nit findings were carried forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
python3 -m unittest tools.lint.tests.test_point_semantics -v(16 tests)python3 tools/lint/point_semantics.py(14 dictionaries, 12 bounded reviewed mappings)python -m unittest discover -s tools/lint/tests -v(86 tests)cargo test --manifest-path tools/verify/Cargo.toml(6 tests)Boundaries
This does not rename or relocate points, create the shared zone dictionary, normalize role or derived-aggregate aspects, add production derivation manifests or routine profiles, certify arbitrary external ontology terms, validate building instances, or modify Engine or Studio.