Skip to content

Add shared zone point resolution - #75

Merged
jscott3201 merged 1 commit into
mainfrom
feat/shared-zone-point-resolution
Aug 23, 2026
Merged

Add shared zone point resolution#75
jscott3201 merged 1 commit into
mainfrom
feat/shared-zone-point-resolution

Conversation

@jscott3201

Copy link
Copy Markdown
Owner

Summary

  • finalize a strict cxf-library/points/v2 contract with explicit imports and compatibility aliases while preserving strict v1 dictionaries
  • move zone_temp, both active zone temperature setpoints, and occ_sensor to points/zone.points.json as their single canonical semantic owner
  • resolve existing VAV and SYS bare names deterministically in Python lint, Rust fault verification, and generated book links
  • preserve 15 dictionaries, 183 concrete records, four compatibility aliases, and every existing fault-card/CXF/vector name and content ID

Validation

  • focused point resolver and semantic tests: 23 passed
  • book point-link tests: 2 passed
  • python3 tools/lint/point_semantics.py twice: 15 dictionaries and 13 bounded reviewed mappings
  • full lint suite: 93 passed
  • Rust tests: 11 passed
  • all 137 fault directories and scenarios passed through the pinned Engine; generated routine verification remained clean at zero deployments
  • dataset harness: 32 passed; tiny FPU replay assertions passed
  • pinned G36 source inventory: 431 release and 693 development files
  • SVG, registry, routine schema, routine semantic, and routine catalog lints passed
  • book generation and mdbook build book passed

Boundaries

This does not add proposal-only zone points, move VAV airflow or equipment-owned records, centralize contextual rht_vlv_cmd bindings, change fault cards/CXF/vectors/runtime behavior, clean up derived aggregates or topology metadata, import production routine profiles, or modify Engine or Studio.

Introduce strict mixed v1/v2 imports and aliases, canonicalize four reviewed zone records, and preserve all fault keys and runtime artifacts.

@jscott3201 jscott3201 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cycle 1 consolidated review: PASS at b001aca4fa4a87c50eef89972b5531f289bedf39.

Both independent reviewers found no blocker or major defect. Exact-head verify and build checks completed successfully, and the PR head remained unchanged after review.

Deferred, non-blocking observation: the Python resolver validates the cross-family resolution contract rather than duplicating every namespace and point-semantic check; tools/lint/point_semantics.py and the Rust verifier retain those checks. No change requested.

@jscott3201
jscott3201 merged commit 2726314 into main Aug 23, 2026
3 checks passed
@jscott3201
jscott3201 deleted the feat/shared-zone-point-resolution branch August 23, 2026 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant