Add shared zone point resolution - #75
Merged
Merged
Conversation
Introduce strict mixed v1/v2 imports and aliases, canonicalize four reviewed zone records, and preserve all fault keys and runtime artifacts.
jscott3201
commented
Aug 23, 2026
jscott3201
left a comment
Owner
Author
There was a problem hiding this comment.
Cycle 1 consolidated review: PASS at b001aca4fa4a87c50eef89972b5531f289bedf39.
Both independent reviewers found no blocker or major defect. Exact-head verify and build checks completed successfully, and the PR head remained unchanged after review.
Deferred, non-blocking observation: the Python resolver validates the cross-family resolution contract rather than duplicating every namespace and point-semantic check; tools/lint/point_semantics.py and the Rust verifier retain those checks. No change requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cxf-library/points/v2contract with explicit imports and compatibility aliases while preserving strict v1 dictionarieszone_temp, both active zone temperature setpoints, andocc_sensortopoints/zone.points.jsonas their single canonical semantic ownerValidation
python3 tools/lint/point_semantics.pytwice: 15 dictionaries and 13 bounded reviewed mappingsmdbook build bookpassedBoundaries
This does not add proposal-only zone points, move VAV airflow or equipment-owned records, centralize contextual
rht_vlv_cmdbindings, change fault cards/CXF/vectors/runtime behavior, clean up derived aggregates or topology metadata, import production routine profiles, or modify Engine or Studio.